Skip to content

Extend ngraph for AdaptivePool operations#6126

Merged
ilyachur merged 1 commit intoopenvinotoolkit:masterfrom
mvafin:op/adaptive_pool/shell
Jun 22, 2021
Merged

Extend ngraph for AdaptivePool operations#6126
ilyachur merged 1 commit intoopenvinotoolkit:masterfrom
mvafin:op/adaptive_pool/shell

Conversation

@mvafin
Copy link
Copy Markdown
Contributor

@mvafin mvafin commented Jun 10, 2021

Details:

  • Add AdaptiveMaxPool-8 and AdaptiveAvgPool-8 to ngraph

Tickets:

  • 56360

@mvafin mvafin requested review from a team, popovaan, rkazants and sadolini and removed request for a team June 10, 2021 10:44
@mvafin mvafin requested review from ilyachur and popovaan June 15, 2021 07:58
@mvafin mvafin requested review from a team and ilyachur June 20, 2021 22:18
Copy link
Copy Markdown
Contributor

@ilyachur ilyachur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you update oneDNN?

@mvafin
Copy link
Copy Markdown
Contributor Author

mvafin commented Jun 21, 2021

Why did you update oneDNN?

I didn't and I don't see that in diff

@ilyachur
Copy link
Copy Markdown
Contributor

Why did you update oneDNN?

I didn't and I don't see that in diff

Looks like the incorrect git merge:
Screenshot 2021-06-22 at 09 30 09

Apply review feedback

Fix code style

Add visitors tests

Check visitor for type attribute
@mvafin mvafin force-pushed the op/adaptive_pool/shell branch from 071faac to 595ca32 Compare June 22, 2021 08:11
@mvafin mvafin requested a review from ilyachur June 22, 2021 08:38
@ilyachur ilyachur merged commit 1bc18d8 into openvinotoolkit:master Jun 22, 2021
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
Apply review feedback

Fix code style

Add visitors tests

Check visitor for type attribute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants