Skip to content

[IE CPU] Reimplement extension nodes via MKLDNNNode API#5784

Merged
dmitry-gorokhov merged 5 commits intoopenvinotoolkit:masterfrom
egorshul:mkldnn_node
Jun 23, 2021
Merged

[IE CPU] Reimplement extension nodes via MKLDNNNode API#5784
dmitry-gorokhov merged 5 commits intoopenvinotoolkit:masterfrom
egorshul:mkldnn_node

Conversation

@egorshul
Copy link
Copy Markdown

@egorshul egorshul commented May 25, 2021

Details:

  • We got rid of using extensions API for CPU implementations

Tickets:

  • 56132

@egorshul egorshul requested review from a team May 25, 2021 08:22
@openvino-pushbot openvino-pushbot added category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common labels May 25, 2021
@egorshul egorshul marked this pull request as draft May 25, 2021 08:54
@egorshul egorshul force-pushed the mkldnn_node branch 6 times, most recently from 8d924cc to 9b19b43 Compare May 27, 2021 18:01
@dmitry-gorokhov
Copy link
Copy Markdown

dmitry-gorokhov commented May 28, 2021

@mandrono could you please review?

@dmitry-gorokhov dmitry-gorokhov added this to the 2021.4 milestone May 28, 2021
@egorshul egorshul marked this pull request as ready for review May 29, 2021 16:21
mandrono
mandrono reviewed May 31, 2021
View reviewed changes
@mandrono
Copy link
Copy Markdown

mandrono commented May 31, 2021 •
edited
Loading

Some general comments:

  1. Please, move creation inDataConfigurators and outDataConfigurators into initSupportedPrimitiveDescriptors
  2. Use getChildEdgesAtPort instead getChildEdgeAt. It's important for nodes which have several outputs.
  3. Use inDims/outDims or getOriginalInputsNumber()/getOriginalOutputsNumber() when you need to get input/output ports num.
  4. Not sure that we really need this, but probably we should replace get_input_element_type()/get_output_element_type() -> getOriginalInputPrecisionAtPort()/getOriginalOutputPrecisionAtPort
    @dmitry-gorokhov what do you think?

@egorshul
Copy link
Copy Markdown
Author

egorshul commented May 31, 2021

@mandrono Fixed in 9ae0261. Thank you!

mandrono
mandrono approved these changes Jun 2, 2021
View reviewed changes
@egorshul
Copy link
Copy Markdown
Author

egorshul commented Jun 2, 2021

@mandrono Thank you! Minor remarks fixed in cee5589

@dmitry-gorokhov dmitry-gorokhov modified the milestones: 2021.4, 2022.1 Jun 7, 2021
@dmitry-gorokhov
Copy link
Copy Markdown

dmitry-gorokhov commented Jun 15, 2021

@egorshul please rebase on latest master to get fresh CI

@egorshul egorshul force-pushed the mkldnn_node branch 2 times, most recently from d2bb17e to 8eda66a Compare June 18, 2021 13:49
@dmitry-gorokhov dmitry-gorokhov merged commit fcc07f8 into openvinotoolkit:master Jun 23, 2021
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
[IE CPU] Reimplement extension nodes via MKLDNNNode API (openvinotool…
fda66c3 
…kit#5784)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

@mandrono mandrono mandrono approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dmitry-gorokhov dmitry-gorokhov

Labels

category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common

Projects

None yet

Milestone

2022.1

Development

Successfully merging this pull request may close these issues.

4 participants

@egorshul @dmitry-gorokhov @mandrono @openvino-pushbot