Correct the sign definition of the result for the FloorMod operator (Sign should be like a divisor, not a dividend)#5188
Merged
lazarevevgeny merged 1 commit intoopenvinotoolkit:masterfrom Apr 12, 2021
Conversation
Merged
tomdol
approved these changes
Apr 12, 2021
lazarevevgeny
approved these changes
Apr 12, 2021
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Apr 23, 2021
liubo-intel
pushed a commit
to liubo-intel/openvino
that referenced
this pull request
Apr 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
This PR is related to:
#5173
This sentence:
The sign of the result is equal to a sign of a dividend
appears to conflict with:
It is the same behaviour like in Python programming language:
floor(x / y) * y + floor_mod(x, y) = x.Both the reference implementation and the CPU plugin take the sign from the divisor and it follows the formula above (see unit tests for this operator for details).
Tickets: