Skip to content

Add keep split output ports without consumers#5136

Merged
lazarevevgeny merged 7 commits intoopenvinotoolkit:masterfrom
iimironov:imironov/setup-split-ports-without-consumers2
Apr 12, 2021
Merged

Add keep split output ports without consumers#5136
lazarevevgeny merged 7 commits intoopenvinotoolkit:masterfrom
iimironov:imironov/setup-split-ports-without-consumers2

Conversation

@iimironov
Copy link
Copy Markdown
Contributor

@iimironov iimironov commented Apr 7, 2021

Ticket: 43534

Description:
Split operation is able to return several outputs. For some cases can be one or several outputs which will not have any consumers. At this case we need to keep ports otherwise we will got incorrect IR. For that cases we connect Result nodes to disconnected ports with special attribute keep_output_port.
keep_output_port attribute to Result node mien that node will not be added to IR but keep output port with shape.

Code:

  • Transformation tests
  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR N/A (not reasonable to implement test. It is covered by e2e testing that is manually passing)
  • Transformation preserves original framework node names

Validation:

  • Unit tests
  • Framework operation tests, no new operations were added: N/A
  • Model Optimizer IR Reader check

Documentation:

  • Supported frameworks operations list: N/A
  • Guide on how to convert the public model: N/A
  • User guide update: N/A

@iimironov iimironov requested a review from a team April 7, 2021 13:49
@iimironov iimironov marked this pull request as draft April 7, 2021 13:49
@openvino-pushbot openvino-pushbot added the category: MO Model Optimizer label Apr 7, 2021
@iimironov iimironov marked this pull request as ready for review April 8, 2021 09:12
@iimironov iimironov requested a review from achetver April 8, 2021 14:59
Copy link
Copy Markdown
Contributor

@achetver achetver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@iimironov iimironov requested a review from lazarevevgeny April 9, 2021 10:32
Copy link
Copy Markdown
Contributor

@mvafin mvafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lazarevevgeny lazarevevgeny merged commit efeff1e into openvinotoolkit:master Apr 12, 2021
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Apr 23, 2021
* Add keep split output ports without consumers

* Fix ir reader for split outputs

* Update unit tests

* Refactoring code according to review

* Fix unit test

* Fix
liubo-intel pushed a commit to liubo-intel/openvino that referenced this pull request Apr 25, 2021
* Add keep split output ports without consumers

* Fix ir reader for split outputs

* Update unit tests

* Refactoring code according to review

* Fix unit test

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: MO Model Optimizer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants