Skip to content

[GNA] Prohibit 2D data reshaping for diagonal layer if it's the first functional layer in network#5097

Merged
dorloff merged 1 commit intoopenvinotoolkit:masterfrom
elilobanova:scale_factor_relu
Apr 12, 2021
Merged

[GNA] Prohibit 2D data reshaping for diagonal layer if it's the first functional layer in network#5097
dorloff merged 1 commit intoopenvinotoolkit:masterfrom
elilobanova:scale_factor_relu

Conversation

@elilobanova
Copy link
Copy Markdown
Contributor

@elilobanova elilobanova commented Apr 3, 2021 •
edited
Loading

Details:

  • Synthetic ScaleShift layer batch size can be changed in some cases to achieve more effective batch size among its values supported by GNA. Change of ScaleShift layer batch size will affect recognition of network groups number if it is the first functional layer handling by GNA lib. It can cause invalid behavior after the model export/import. So its reshape is prohibited in this case.
  • Fixed a bug with ScaleShift layer execution in GNA_SW_FP32 mode if rows padding isn't 0.
  • Fixed a bug with export of NCHW models with convolution: invalid inputs/outputs name size in transposition info.

Tickets:

@elilobanova elilobanova requested review from a team April 3, 2021 13:03
@openvino-pushbot openvino-pushbot added category: GNA OpenVINO GNA plugin category: IE Tests OpenVINO Test: plugins and common labels Apr 3, 2021
@elilobanova elilobanova assigned p-rozen and kbruniec and unassigned p-rozen and kbruniec Apr 5, 2021
kbruniec
kbruniec suggested changes Apr 9, 2021
View reviewed changes
@dorloff dorloff merged commit 69be1f1 into openvinotoolkit:master Apr 12, 2021
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Apr 23, 2021
@elilobanova @mryzhov
[GNA] Prohibit 2D data reshaping for diagonal layer if it's the first…
cedd188 
… functional layer in network (openvinotoolkit#5097)
tadamowicz pushed a commit to tadamowicz/openvino that referenced this pull request Aug 30, 2023
@elilobanova @dood-apo
[GNA] Prohibit 2D data reshaping for diagonal layer if it's the first…
7c7b9d2 
… functional layer in network (openvinotoolkit#5097)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p-rozen p-rozen Awaiting requested review from p-rozen

@admitriev-gna admitriev-gna Awaiting requested review from admitriev-gna

1 more reviewer

@kbruniec kbruniec kbruniec approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

category: GNA OpenVINO GNA plugin category: IE Tests OpenVINO Test: plugins and common

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@elilobanova @kbruniec @openvino-pushbot @p-rozen @dorloff