Skip to content

Compression of constants during serialization#4846

Merged
tomdol merged 14 commits intoopenvinotoolkit:masterfrom
blesniewski:const_compression
Mar 31, 2021
Merged

Compression of constants during serialization#4846
tomdol merged 14 commits intoopenvinotoolkit:masterfrom
blesniewski:const_compression

Conversation

@blesniewski
Copy link
Copy Markdown
Contributor

@blesniewski blesniewski commented Mar 17, 2021 •
edited
Loading

Details:

  • Added a class to handle writing (and compression) of constant nodes to binary file during serialization.
  • Added the class to the XMLSerializer in place of the binary handle.

Tickets:

  • 45110

@blesniewski blesniewski self-assigned this Mar 17, 2021
elszkowski
elszkowski reviewed Mar 22, 2021
View reviewed changes
@jdanieck jdanieck self-requested a review March 23, 2021 09:16
@blesniewski blesniewski added the category: Core OpenVINO Core (aka ngraph) label Mar 23, 2021
@blesniewski blesniewski requested review from ilyachur and sdurawa March 23, 2021 16:04
@blesniewski blesniewski marked this pull request as ready for review March 23, 2021 16:04
@blesniewski blesniewski requested a review from a team March 23, 2021 16:04
ilyachur
ilyachur reviewed Mar 24, 2021
View reviewed changes
@ilyachur
Copy link
Copy Markdown
Contributor

ilyachur commented Mar 24, 2021

Please add new tests to cover this functionality

@ilyachur ilyachur added the pr: needs tests PR needs tests updating label Mar 24, 2021
@ilyachur ilyachur added this to the 2021.4 milestone Mar 24, 2021
@blesniewski blesniewski requested a review from a team March 25, 2021 13:31
elszkowski
elszkowski approved these changes Mar 25, 2021
View reviewed changes
@blesniewski blesniewski requested a review from ilyachur March 26, 2021 09:45
@ilyachur ilyachur removed the pr: needs tests PR needs tests updating label Mar 26, 2021
@jdanieck jdanieck self-requested a review March 30, 2021 11:31
elszkowski
elszkowski reviewed Mar 31, 2021
View reviewed changes
@tomdol tomdol merged commit 5363c8d into openvinotoolkit:master Mar 31, 2021
@blesniewski blesniewski deleted the const_compression branch March 31, 2021 11:12
luo-cheng2021 pushed a commit to luo-cheng2021/openvino that referenced this pull request Apr 7, 2021
@bartoszLesniewski @luo-cheng2021
Compression of constants during serialization (openvinotoolkit#4846)
de43fcd
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Apr 23, 2021
@bartoszLesniewski @mryzhov
Compression of constants during serialization (openvinotoolkit#4846)
290afb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdurawa sdurawa Awaiting requested review from sdurawa

@GlebKazantaev GlebKazantaev Awaiting requested review from GlebKazantaev

4 more reviewers

@elszkowski elszkowski elszkowski approved these changes

@ilyachur ilyachur ilyachur approved these changes

@tomdol tomdol tomdol approved these changes

@jdanieck jdanieck jdanieck approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@blesniewski blesniewski

Labels

category: Core OpenVINO Core (aka ngraph)

Projects

None yet

Milestone

2021.4

Development

Successfully merging this pull request may close these issues.

6 participants

@blesniewski @ilyachur @tomdol @jdanieck @elszkowski @bartoszLesniewski