Skip to content

Corrections in MO to fix performance drop in Interpolate-4 when mode=linear instead of linear_onnx#4488

Merged
lazarevevgeny merged 9 commits intoopenvinotoolkit:masterfrom
vgavrilo:vgavrilo/performance-fix-for-linear-interpolate-in-mo
Feb 27, 2021
Merged

Corrections in MO to fix performance drop in Interpolate-4 when mode=linear instead of linear_onnx#4488
lazarevevgeny merged 9 commits intoopenvinotoolkit:masterfrom
vgavrilo:vgavrilo/performance-fix-for-linear-interpolate-in-mo

Conversation

@vgavrilo
Copy link
Copy Markdown
Contributor

@vgavrilo vgavrilo commented Feb 25, 2021

Corrections in MO to fix performance drop in Interpolate-4 when mode=linear instead of linear_onnx.
Ticket: #49045

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR: Yes
  • Transformation preserves node names: Yes

Validation:

  • Unit tests
  • Framework layer tests: N/A because there are no new supported layers
  • Transformation tests: N/A
  • e2e model test: N/A because there is no new model
  • MO IR Reader tests: N/A because there is no new model

Documentation:

  • Supported frameworks layers list: N/A because there are no new operations
  • Supported public models list: N/A because there is no new public model
  • New operations specification: N/A because there are no new operations
  • Guide on how to convert the public model: N/A because there is no new public model
  • User guide update: N/A because there is no need to update common user guide

Other:

  • Sample/Demo application to infer the model: N/A because there is now new model

@vgavrilo vgavrilo marked this pull request as ready for review February 25, 2021 15:00
@vgavrilo vgavrilo requested review from a team, achetver, evolosen, iimironov and lazarevevgeny and removed request for a team February 25, 2021 15:00
@vgavrilo
Copy link
Copy Markdown
Contributor Author

@iimironov, @achetver, @evolosen, @lazarevevgeny, please, see this PR (#4488)

Comment thread model-optimizer/extensions/back/LinearToLinearONNXReplacer.py Outdated
Copy link
Copy Markdown
Contributor

@achetver achetver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@vgavrilo
Copy link
Copy Markdown
Contributor Author

@iimironov, @evolosen, @lazarevevgeny, please, see this PR (#4488)

Copy link
Copy Markdown
Contributor

@lazarevevgeny lazarevevgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Waiting for benchmark run results before merge.

@lazarevevgeny lazarevevgeny merged commit b15a70c into openvinotoolkit:master Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants