Skip to content

[CPU] returned old behavior for fp32 avx2 1x1 conv with dw conv fusing#4484

Merged
eshoguli merged 1 commit intoopenvinotoolkit:masterfrom
antonvor:feature/dw_conv_fusing_avx2_fp32
Mar 29, 2021
Merged

[CPU] returned old behavior for fp32 avx2 1x1 conv with dw conv fusing#4484
eshoguli merged 1 commit intoopenvinotoolkit:masterfrom
antonvor:feature/dw_conv_fusing_avx2_fp32

Conversation

@antonvor
Copy link
Copy Markdown
Contributor

@antonvor antonvor commented Feb 25, 2021 •
edited
Loading

PR in oneDNN: openvinotoolkit/oneDNN#36
PR with tests: #4957

@antonvor antonvor self-assigned this Feb 25, 2021
@antonvor antonvor force-pushed the feature/dw_conv_fusing_avx2_fp32 branch 3 times, most recently from ba2ae6e to c5c3ac3 Compare March 2, 2021 01:21
@antonvor antonvor marked this pull request as ready for review March 2, 2021 01:24
@antonvor antonvor requested review from a team March 2, 2021 01:24
@antonvor antonvor force-pushed the feature/dw_conv_fusing_avx2_fp32 branch from c5c3ac3 to fab0a29 Compare March 2, 2021 01:39
@antonvor antonvor changed the title Feature/dw conv fusing avx2 fp32 [CPU] returned old behavior for avx2 fp32 dw conv fusing + added tests Mar 2, 2021
@antonvor antonvor requested a review from dmitry-gorokhov March 2, 2021 01:59
@antonvor antonvor added this to the 2021.3 milestone Mar 2, 2021
@antonvor
Copy link
Copy Markdown
Contributor Author

antonvor commented Mar 2, 2021

@dmitry-gorokhov could you please review?

@antonvor antonvor force-pushed the feature/dw_conv_fusing_avx2_fp32 branch from fab0a29 to ab9de92 Compare March 2, 2021 11:49
@antonvor antonvor force-pushed the feature/dw_conv_fusing_avx2_fp32 branch 2 times, most recently from db11c2a to c5f8b2f Compare March 9, 2021 12:00
@ilya-lavrenov
Copy link
Copy Markdown
Contributor

ilya-lavrenov commented Mar 10, 2021

is it needed for 2021.3? Cherry-pick should be needed in this case

@ilya-lavrenov ilya-lavrenov modified the milestones: 2021.3, 2021.4 Mar 10, 2021
@antonvor antonvor force-pushed the feature/dw_conv_fusing_avx2_fp32 branch from de140f4 to c90c9b6 Compare March 22, 2021 09:40
@antonvor
Copy link
Copy Markdown
Contributor Author

antonvor commented Mar 22, 2021

@maxnick could you please review?

@antonvor antonvor changed the title [CPU] returned old behavior for avx2 fp32 dw conv fusing + added tests [CPU] returned old behavior for fp32 avx2 1x1 conv with dw conv fusing + added tests Mar 22, 2021
@maxnick maxnick self-assigned this Mar 22, 2021
@antonvor antonvor force-pushed the feature/dw_conv_fusing_avx2_fp32 branch 4 times, most recently from fa2a545 to f412d21 Compare March 22, 2021 15:48
maxnick
maxnick reviewed Mar 23, 2021
View reviewed changes
@antonvor antonvor force-pushed the feature/dw_conv_fusing_avx2_fp32 branch from f412d21 to 0cc40e4 Compare March 24, 2021 11:09
@antonvor
Copy link
Copy Markdown
Contributor Author

antonvor commented Mar 24, 2021

@maxnick thanks for your review
@dmitry-gorokhov could you finally review please?

maxnick
maxnick approved these changes Mar 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@maxnick maxnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check comments in the linked oneDNN PR.

@antonvor antonvor force-pushed the feature/dw_conv_fusing_avx2_fp32 branch 4 times, most recently from 16c96d2 to 3b59134 Compare March 25, 2021 09:02
@antonvor antonvor mentioned this pull request Mar 25, 2021
Closed
@antonvor antonvor added the category: CPU OpenVINO CPU plugin label Mar 25, 2021
@antonvor antonvor force-pushed the feature/dw_conv_fusing_avx2_fp32 branch from 3b59134 to 8183c63 Compare March 25, 2021 09:21
@antonvor antonvor changed the title [CPU] returned old behavior for fp32 avx2 1x1 conv with dw conv fusing + added tests [CPU] returned old behavior for fp32 avx2 1x1 conv with dw conv fusing Mar 25, 2021
@antonvor antonvor force-pushed the feature/dw_conv_fusing_avx2_fp32 branch from 8183c63 to 9da4e82 Compare March 25, 2021 11:00
dmitry-gorokhov
dmitry-gorokhov reviewed Mar 25, 2021
View reviewed changes
@antonvor antonvor force-pushed the feature/dw_conv_fusing_avx2_fp32 branch 2 times, most recently from 00756b5 to 03d5dd7 Compare March 26, 2021 13:55
@antonvor antonvor force-pushed the feature/dw_conv_fusing_avx2_fp32 branch from 03d5dd7 to 3ece964 Compare March 29, 2021 07:22
@eshoguli eshoguli merged commit 4d112b1 into openvinotoolkit:master Mar 29, 2021
luo-cheng2021 pushed a commit to luo-cheng2021/openvino that referenced this pull request Apr 7, 2021
@antonvor @luo-cheng2021
[CPU] returned old behavior for fp32 avx2 1x1 conv with dw conv fusing (
eace30c 
openvinotoolkit#4484)
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Apr 23, 2021
@antonvor @mryzhov
[CPU] returned old behavior for fp32 avx2 1x1 conv with dw conv fusing (
8af53e7 
openvinotoolkit#4484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxnick maxnick maxnick approved these changes

+1 more reviewer

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@antonvor antonvor

@maxnick maxnick

Labels

category: CPU OpenVINO CPU plugin

Projects

None yet

Milestone

2021.4

Development

Successfully merging this pull request may close these issues.

5 participants

@antonvor @ilya-lavrenov @dmitry-gorokhov @maxnick @eshoguli