Skip to content

[GNA] Enable Zero Padding#4252

Merged
dorloff merged 5 commits intoopenvinotoolkit:masterfrom
kbruniec:gna-cnn2d-zero-padding
Feb 24, 2021
Merged

[GNA] Enable Zero Padding#4252
dorloff merged 5 commits intoopenvinotoolkit:masterfrom
kbruniec:gna-cnn2d-zero-padding

Conversation

@kbruniec
Copy link
Copy Markdown
Contributor

@kbruniec kbruniec commented Feb 9, 2021 •
edited
Loading

  • Fix CNN2D stride order
  • Enable pooling
  • Add tests including one based on the real life model structure.

@kbruniec kbruniec requested a review from a team February 9, 2021 14:49
@openvino-pushbot openvino-pushbot added the category: GNA OpenVINO GNA plugin label Feb 9, 2021
@kbruniec kbruniec force-pushed the gna-cnn2d-zero-padding branch from a7d79b1 to 01dff57 Compare February 10, 2021 16:04
@kbruniec
Copy link
Copy Markdown
Contributor Author

kbruniec commented Feb 12, 2021

I recommend to merge

elilobanova
elilobanova reviewed Feb 12, 2021
View reviewed changes
Comment thread inference-engine/src/gna_plugin/gna_graph_compiler.cpp Outdated
@kbruniec kbruniec force-pushed the gna-cnn2d-zero-padding branch 2 times, most recently from 30e1c3f to eee315d Compare February 16, 2021 09:37
bsochack
bsochack reviewed Feb 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@bsochack bsochack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • missing tests
  • this change is not only about zero padding. It also adds FP32 implementation

Comment thread inference-engine/src/gna_plugin/gna_graph_compiler.hpp Outdated
@kbruniec kbruniec force-pushed the gna-cnn2d-zero-padding branch 3 times, most recently from cf44143 to 38775a5 Compare February 22, 2021 13:14
@kbruniec kbruniec requested a review from a team February 22, 2021 13:14
@kbruniec kbruniec force-pushed the gna-cnn2d-zero-padding branch from 38775a5 to eb92e82 Compare February 23, 2021 08:29
@kbruniec kbruniec force-pushed the gna-cnn2d-zero-padding branch from eb92e82 to e1e723a Compare February 23, 2021 14:56
@kbruniec
Copy link
Copy Markdown
Contributor Author

kbruniec commented Feb 24, 2021

@elilobanova, @bsochack, As you reviewed this PR and your issues were addressed could you take a look and possibly approve?

@dorloff dorloff merged commit 304c31d into openvinotoolkit:master Feb 24, 2021
tadamowicz pushed a commit to tadamowicz/openvino that referenced this pull request Aug 30, 2023
@kbruniec @dood-apo
[GNA] Enable Zero Padding (openvinotoolkit#4252)
cb9d533 
* [GNA] Enable Zero Padding

   Fix CNN2D stride order
   Draft pooling

* Implement CNN2D FP32 mode in GNAPlugin

* Move padding flag to Policy

* Remove inactive output rotation code from CNN2D graph compiler routine (review)

* Add ConvReluSequence tests to gnaFuncTest as DISABLED
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p-rozen p-rozen Awaiting requested review from p-rozen

@admitriev-gna admitriev-gna Awaiting requested review from admitriev-gna

@nkogteva nkogteva Awaiting requested review from nkogteva

2 more reviewers

@bsochack bsochack bsochack left review comments

@elilobanova elilobanova elilobanova approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

category: GNA OpenVINO GNA plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kbruniec @bsochack @elilobanova @openvino-pushbot @dorloff