fix batch adding to init value of read value#4187
Merged
lazarevevgeny merged 23 commits intoopenvinotoolkit:masterfrom Mar 31, 2021
Merged
fix batch adding to init value of read value#4187lazarevevgeny merged 23 commits intoopenvinotoolkit:masterfrom
lazarevevgeny merged 23 commits intoopenvinotoolkit:masterfrom
Conversation
vgavrilo
approved these changes
Feb 10, 2021
mvafin
reviewed
Feb 11, 2021
Contributor
mvafin
left a comment
There was a problem hiding this comment.
Generally, it looks good to me.
mvafin
approved these changes
Feb 19, 2021
e-nugmanova
reviewed
Feb 25, 2021
e-nugmanova
reviewed
Feb 25, 2021
e-nugmanova
reviewed
Feb 25, 2021
e-nugmanova
reviewed
Feb 25, 2021
iimironov
approved these changes
Feb 25, 2021
lazarevevgeny
suggested changes
Mar 15, 2021
# Conflicts: # model-optimizer/mo/front/kaldi/loader/loader.py
lazarevevgeny
suggested changes
Mar 22, 2021
model-optimizer/extensions/front/kaldi/memoryoffset_batch_update.py
Outdated
Show resolved
Hide resolved
# Conflicts: # model-optimizer/extensions/middle/ReplaceSpliceNodePattern.py
lazarevevgeny
approved these changes
Mar 31, 2021
luo-cheng2021
pushed a commit
to luo-cheng2021/openvino
that referenced
this pull request
Apr 7, 2021
* fix batch adding to init value of read value * fix for batch in Kaldi models * added broadcast to be able reshape in IE * test fixes, added batch broadcasting to created constants * pep fixes * move all changes to 1 transformation * added unit test and fix insertSelect transformation * added comments * remove unneeded params search * fix element_size to send correct batch * fix update batch in element_size * couple fixes * update BOM file * fix review comments * review fixes * review fixes * fix license headers
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Apr 23, 2021
* fix batch adding to init value of read value * fix for batch in Kaldi models * added broadcast to be able reshape in IE * test fixes, added batch broadcasting to created constants * pep fixes * move all changes to 1 transformation * added unit test and fix insertSelect transformation * added comments * remove unneeded params search * fix element_size to send correct batch * fix update batch in element_size * couple fixes * update BOM file * fix review comments * review fixes * review fixes * fix license headers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Changed port for batch extraction to avoid loop in case of LSTM. Now MO takes batch from the first Parameter. In original Kaldi there is no batch, we add it in MO and have not change anywhere during graph transformations, so using batch from Parameter is valid approach for Kaldi and allows to reshape stateful networks by batch.
Ticket: 23956
Code:
Validation:
Documentation: