Skip to content

fix batch adding to init value of read value#4187

Merged
lazarevevgeny merged 23 commits intoopenvinotoolkit:masterfrom
sadolini:batch_for_kaldi
Mar 31, 2021
Merged

fix batch adding to init value of read value#4187
lazarevevgeny merged 23 commits intoopenvinotoolkit:masterfrom
sadolini:batch_for_kaldi

Conversation

@sadolini
Copy link
Copy Markdown
Contributor

@sadolini sadolini commented Feb 4, 2021

Description: Changed port for batch extraction to avoid loop in case of LSTM. Now MO takes batch from the first Parameter. In original Kaldi there is no batch, we add it in MO and have not change anywhere during graph transformations, so using batch from Parameter is valid approach for Kaldi and allows to reshape stateful networks by batch.

Ticket: 23956

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR
  • Transformation preserves original framework node names Not applicable, no new transformations

Validation:

  • Unit tests
  • Framework operation tests Not applicable, no new operations
  • Transformation tests Not applicable, no new transformations
  • e2e model test with an update of ./tests/e2e_oss/utils/reshape_utils.py Should be done in separate PR
  • Model Optimizer IR Reader check Not applicable, no new operations

Documentation:

  • Supported frameworks operations list Not applicable, no new operations
  • Supported public models list Not applicable, no new models
  • New operations specification Not applicable, no new operations
  • Guide on how to convert the public model Not applicable, no new models
  • User guide update Not applicable, have not mentioned that Kaldi models can't be with batch > 1

@sadolini sadolini requested review from a team, e-nugmanova, iimironov, mvafin and vgavrilo and removed request for a team February 9, 2021 21:01
@sadolini sadolini marked this pull request as ready for review February 9, 2021 21:09
@sadolini sadolini requested a review from a team February 9, 2021 21:09
Copy link
Copy Markdown
Contributor

@mvafin mvafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, it looks good to me.

@lazarevevgeny lazarevevgeny removed the request for review from e-nugmanova February 17, 2021 11:59
@lazarevevgeny lazarevevgeny added this to the 2021.4 milestone Feb 20, 2021
@sadolini sadolini marked this pull request as draft March 9, 2021 21:09
@sadolini sadolini marked this pull request as ready for review March 10, 2021 07:57
@sadolini sadolini requested a review from e-nugmanova March 10, 2021 07:58
@sadolini sadolini marked this pull request as draft March 16, 2021 07:41
@sadolini sadolini requested a review from lazarevevgeny March 21, 2021 21:30
@lazarevevgeny lazarevevgeny marked this pull request as ready for review March 22, 2021 14:41
# Conflicts:
#	model-optimizer/extensions/middle/ReplaceSpliceNodePattern.py
@sadolini sadolini requested a review from lazarevevgeny March 29, 2021 12:45
@lazarevevgeny lazarevevgeny merged commit ffa467a into openvinotoolkit:master Mar 31, 2021
luo-cheng2021 pushed a commit to luo-cheng2021/openvino that referenced this pull request Apr 7, 2021
* fix batch adding to init value of read value

* fix for batch in Kaldi models

* added broadcast to be able reshape in IE

* test fixes, added batch broadcasting to created constants

* pep fixes

* move all changes to 1 transformation

* added unit test and fix insertSelect transformation

* added comments

* remove unneeded params search

* fix element_size to send correct batch

* fix update batch in element_size

* couple fixes

* update BOM file

* fix review comments

* review fixes

* review fixes

* fix license headers
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Apr 23, 2021
* fix batch adding to init value of read value

* fix for batch in Kaldi models

* added broadcast to be able reshape in IE

* test fixes, added batch broadcasting to created constants

* pep fixes

* move all changes to 1 transformation

* added unit test and fix insertSelect transformation

* added comments

* remove unneeded params search

* fix element_size to send correct batch

* fix update batch in element_size

* couple fixes

* update BOM file

* fix review comments

* review fixes

* review fixes

* fix license headers
@sadolini sadolini deleted the batch_for_kaldi branch December 14, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants