Skip to content

Fixes for Object Detection SSD Python sample#3518

Merged
mryzhov merged 1 commit intoopenvinotoolkit:masterfrom
mmakridi:fix_object_detection_sample_ssd_python
Dec 8, 2020
Merged

Fixes for Object Detection SSD Python sample#3518
mryzhov merged 1 commit intoopenvinotoolkit:masterfrom
mmakridi:fix_object_detection_sample_ssd_python

Conversation

@mmakridi
Copy link
Copy Markdown

@mmakridi mmakridi commented Dec 8, 2020

  • added check so that sample only supports networks with one input
  • moved ngraph-related operations to related segment of the sample
  • fix for output image not being saved correctly

* added check so that sample only supports networks with one input
* moved ngraph-realted operations to related segment of the sample
* fix for output image not being saved correcly due
@mmakridi mmakridi added bug Something isn't working category: samples OpenVINO Runtime Samples labels Dec 8, 2020
@mmakridi mmakridi requested a review from mryzhov December 8, 2020 14:47
@mmakridi mmakridi self-assigned this Dec 8, 2020
@mmakridi
Copy link
Copy Markdown
Author

mmakridi commented Dec 8, 2020

@mryzhov please have a look
while testing the sample on 1-input topology I've noticed that sample fails to save the resulting image due to args.input[imid] working incorrectly when only one input image is supported (in this case, args.input is not list anymore, but string containing the input filename). So I fixed this too, as without this fix sample would be in non-working condition

@mmakridi mmakridi marked this pull request as ready for review December 8, 2020 19:56
@mmakridi mmakridi requested a review from a team December 8, 2020 19:56
Copy link
Copy Markdown
Contributor

@mryzhov mryzhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgfm

@mryzhov mryzhov merged commit 7d8144f into openvinotoolkit:master Dec 8, 2020
@mmakridi mmakridi deleted the fix_object_detection_sample_ssd_python branch December 9, 2020 13:11
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Dec 11, 2020
* added check so that sample only supports networks with one input
* moved ngraph-realted operations to related segment of the sample
* fix for output image not being saved correcly due
vzinovie pushed a commit to vzinovie/openvino that referenced this pull request Dec 15, 2020
* added check so that sample only supports networks with one input
* moved ngraph-realted operations to related segment of the sample
* fix for output image not being saved correcly due
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Dec 16, 2020
* added check so that sample only supports networks with one input
* moved ngraph-realted operations to related segment of the sample
* fix for output image not being saved correcly due
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Jan 14, 2021
* added check so that sample only supports networks with one input
* moved ngraph-realted operations to related segment of the sample
* fix for output image not being saved correcly due
jiwaszki pushed a commit to akuporos/openvino that referenced this pull request Jan 15, 2021
* added check so that sample only supports networks with one input
* moved ngraph-realted operations to related segment of the sample
* fix for output image not being saved correcly due
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working category: samples OpenVINO Runtime Samples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants