Skip to content

[NPU]Move VCL API from compiler_adapter to utils#34662

Merged
pereanub merged 7 commits intoopenvinotoolkit:masterfrom
WenjingKangIntel:wenjing/mv-vclapi-to-utils
Apr 3, 2026
Merged

[NPU]Move VCL API from compiler_adapter to utils#34662
pereanub merged 7 commits intoopenvinotoolkit:masterfrom
WenjingKangIntel:wenjing/mv-vclapi-to-utils

Conversation

@WenjingKangIntel
Copy link
Copy Markdown
Contributor

@WenjingKangIntel WenjingKangIntel commented Mar 12, 2026 •
edited
Loading

Details:

  • Create a folder vcl in utils and move VCLApi to utils from compiler_adapter

Tickets:

AI Assistance:

  • AI assistance used: no / yes
  • If yes, summarize how AI was used and what human validation was performed (build/tests/manual checks).

@WenjingKangIntel WenjingKangIntel requested review from a team as code owners March 12, 2026 11:45
@github-actions github-actions bot added category: build OpenVINO cmake script / infra category: NPU OpenVINO NPU plugin labels Mar 12, 2026
@WenjingKangIntel WenjingKangIntel force-pushed the wenjing/mv-vclapi-to-utils branch 6 times, most recently from aac6434 to 0b90283 Compare March 13, 2026 06:29
@WenjingKangIntel WenjingKangIntel changed the title Move VCL API from compiler_adapter to utils [NPU]Move VCL API from compiler_adapter to utils Mar 16, 2026
@WenjingKangIntel WenjingKangIntel force-pushed the wenjing/mv-vclapi-to-utils branch 4 times, most recently from 9e5c748 to 152c0b9 Compare March 19, 2026 03:24
pereanub
pereanub approved these changes Mar 19, 2026
View reviewed changes
@WenjingKangIntel WenjingKangIntel force-pushed the wenjing/mv-vclapi-to-utils branch from 152c0b9 to d4d2cfe Compare March 19, 2026 08:40
XinWangIntel
XinWangIntel reviewed Mar 19, 2026
View reviewed changes
@WenjingKangIntel
Move VCL API to utils
5146d84 
Signed-off-by: Kang, Wenjing <wenjing.kang@intel.com>
@WenjingKangIntel
Rename openvino_npu_driver_compiler_adapter to openvino_npu_compiler_…
5547de9 
…adapter

Signed-off-by: Kang, Wenjing <wenjing.kang@intel.com>
@WenjingKangIntel
Move add_subdirectory of vcl
4d0442b 
Signed-off-by: Kang, Wenjing <wenjing.kang@intel.com>
@WenjingKangIntel WenjingKangIntel force-pushed the wenjing/mv-vclapi-to-utils branch from 6bbdee2 to 4d0442b Compare March 24, 2026 06:22
@XinWangIntel
Copy link
Copy Markdown
Contributor

XinWangIntel commented Mar 26, 2026

@lmielick please help to review again

@DanLiu2Intel DanLiu2Intel requested a review from lmielick March 30, 2026 02:42
lmielick
lmielick reviewed Mar 30, 2026
View reviewed changes
@DanLiu2Intel DanLiu2Intel force-pushed the wenjing/mv-vclapi-to-utils branch from c681f64 to 52141af Compare March 31, 2026 06:28
@DanLiu2Intel DanLiu2Intel force-pushed the wenjing/mv-vclapi-to-utils branch from 6737dd0 to 1ff95cd Compare April 1, 2026 09:01
lmielick
lmielick reviewed Apr 1, 2026
View reviewed changes
src/plugins/intel_npu/src/compiler_adapter/CMakeLists.txt
source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR} FILES ${SOURCES})

add_library(${TARGET_NAME} STATIC ${SOURCES})
add_library(${TARGET_NAME} STATIC ${SOURCES} $<TARGET_OBJECTS:openvino_npu_vcl_utils>)
Copy link
Copy Markdown
Contributor

@lmielick lmielick Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was only needed in old cmake,
It should be enough to just link it with:
target_link_libraries(${TARGET_NAME} PRIVATE openvino_npu_vcl_utils)
that's more robust as will propagate public interface

Copy link
Copy Markdown
Contributor

@DanLiu2Intel DanLiu2Intel Apr 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utilizing link libraries lead to dependency export issues with openvino_npu_vcl_utils(OBJECT ), as this PR's (use target_link_libraries to link vcl_utils ) report. And openvino_npu_vcl_utils is OBJECT target will not be exported.

CMake Error: install(EXPORT "OpenVINOTargets" ...) includes target "openvino_npu_compiler_adapter" which requires target "openvino_npu_vcl_utils" that is not in any export set.

@PatrikStepan PatrikStepan added this pull request to the merge queue Apr 3, 2026
github-merge-queue bot pushed a commit that referenced this pull request Apr 3, 2026
@WenjingKangIntel @DanLiu2Intel
[NPU]Move VCL API from compiler_adapter to utils (#34662)
e69f8cc 
### Details:
- Create a folder `vcl` in `utils` and move `VCLApi` to `utils` from
`compiler_adapter`
### Tickets:
 - *CVS-182731*

### AI Assistance:
 - *AI assistance used: no / yes*
- *If yes, summarize how AI was used and what human validation was
performed (build/tests/manual checks).*

---------

Signed-off-by: Kang, Wenjing <wenjing.kang@intel.com>
Co-authored-by: Liu, Dan1 <dan1.liu@intel.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 3, 2026
@pereanub pereanub added this pull request to the merge queue Apr 3, 2026
Merged via the queue into openvinotoolkit:master with commit dca3df7 Apr 3, 2026
186 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XinWangIntel XinWangIntel XinWangIntel approved these changes

@lmielick lmielick lmielick approved these changes

@DanLiu2Intel DanLiu2Intel DanLiu2Intel left review comments

@pereanub pereanub pereanub approved these changes

Assignees

No one assigned

Labels

category: build OpenVINO cmake script / infra category: NPU OpenVINO NPU plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@WenjingKangIntel @XinWangIntel @pereanub @lmielick @DanLiu2Intel