Deprecate global element types#3444
Merged
ilyachur merged 9 commits intoopenvinotoolkit:masterfrom Dec 2, 2020
Merged
Conversation
ilya-lavrenov
approved these changes
Dec 2, 2020
tomdol
suggested changes
Dec 2, 2020
ngraph/frontend/onnx_import/include/onnx_import/core/value_info.hpp
Outdated
Show resolved
Hide resolved
ngraph/frontend/onnx_import/include/onnx_import/core/tensor.hpp
Outdated
Show resolved
Hide resolved
…deprecate_global_types
tomdol
approved these changes
Dec 2, 2020
elszkowski
reviewed
Dec 3, 2020
| size_t bitwidth() const; | ||
| // The name of this type, the enum name of this type | ||
| const std::string& get_type_name() const; | ||
| bool operator==(const Type_t& other) const; |
There was a problem hiding this comment.
Have you try to remove all of comparing functions and let allow compiler to use cast to enum (l:127) to do comparators.
| typedef std::vector<Type> TypeVector; | ||
|
|
||
| NGRAPH_DEPRECATED( | ||
| "This global element type was deprecated. Please use Type_t::undefined instead.") |
There was a problem hiding this comment.
Just for my curiosity. Why we don't use constexpr and use extern for variables which might be inline?
Contributor
Author
There was a problem hiding this comment.
I will recheck, if it works I will change it and remove deprecation.
evolosen
pushed a commit
to evolosen/openvino
that referenced
this pull request
Dec 3, 2020
* Removed global types * Fixed ONNX importer and nGraph tests * Fixed code style * Disable some warnings for Windows * Try to fix python build * Extend deprecation message * Fixed code style * Fixed comments
ilyachur
added a commit
to ilyachur/openvino
that referenced
this pull request
Dec 3, 2020
This reverts commit 071fb9d.
ilyachur
added a commit
that referenced
this pull request
Dec 4, 2020
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Dec 11, 2020
* Removed global types * Fixed ONNX importer and nGraph tests * Fixed code style * Disable some warnings for Windows * Try to fix python build * Extend deprecation message * Fixed code style * Fixed comments
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Dec 11, 2020
…inotoolkit#3468) * Revert "Deprecate global element types (openvinotoolkit#3444)" This reverts commit 071fb9d. * Fixed code style
vzinovie
pushed a commit
to vzinovie/openvino
that referenced
this pull request
Dec 15, 2020
…inotoolkit#3468) * Revert "Deprecate global element types (openvinotoolkit#3444)" This reverts commit 071fb9d. * Fixed code style
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Dec 16, 2020
* Removed global types * Fixed ONNX importer and nGraph tests * Fixed code style * Disable some warnings for Windows * Try to fix python build * Extend deprecation message * Fixed code style * Fixed comments
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Dec 16, 2020
…inotoolkit#3468) * Revert "Deprecate global element types (openvinotoolkit#3444)" This reverts commit 071fb9d. * Fixed code style
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Jan 14, 2021
* Removed global types * Fixed ONNX importer and nGraph tests * Fixed code style * Disable some warnings for Windows * Try to fix python build * Extend deprecation message * Fixed code style * Fixed comments
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Jan 14, 2021
…inotoolkit#3468) * Revert "Deprecate global element types (openvinotoolkit#3444)" This reverts commit 071fb9d. * Fixed code style
jiwaszki
pushed a commit
to akuporos/openvino
that referenced
this pull request
Jan 15, 2021
* Removed global types * Fixed ONNX importer and nGraph tests * Fixed code style * Disable some warnings for Windows * Try to fix python build * Extend deprecation message * Fixed code style * Fixed comments
jiwaszki
pushed a commit
to akuporos/openvino
that referenced
this pull request
Jan 15, 2021
…inotoolkit#3468) * Revert "Deprecate global element types (openvinotoolkit#3444)" This reverts commit 071fb9d. * Fixed code style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I deprecated global element type variables from nGraph code.
It is needed to avoid issues with tests initialisations when we build inference engine as a static library. For more information have a look this PR: #3219
I already tried to remove these global variables in PR: #3279 but it is not backward compatible changes.
So in this PR I marked as deprecated global element type variables and fixed nGraph build in order to avoid deprecation warnings.
Majority of changes in this PR are changing
ngraph::element::[f32,i32,u8, ...]tongraph::element::Type_t::[f32,i32,u8, ...]