Skip to content

Remove ops from Layer Creator/ Node Converter - part 3#3356

Merged
ilyachur merged 17 commits intoopenvinotoolkit:masterfrom
blesniewski:remove_and_fix_ops_part3
Dec 8, 2020
Merged

Remove ops from Layer Creator/ Node Converter - part 3#3356
ilyachur merged 17 commits intoopenvinotoolkit:masterfrom
blesniewski:remove_and_fix_ops_part3

Conversation

@blesniewski
Copy link
Copy Markdown
Contributor

@blesniewski blesniewski commented Nov 25, 2020

Removing ops from layer creator/ node converter:

  • Convert
  • DepthToSpace
  • MVN
  • NormalizeL2
  • NotEqual
  • Subtract

42362

@blesniewski blesniewski requested a review from sdurawa November 25, 2020 13:27
@blesniewski blesniewski self-assigned this Nov 25, 2020
@blesniewski blesniewski changed the title Remove and fix ops part3 Remove ops from Layer Creator/ Node Converter - part 3 Nov 25, 2020
Comment thread ngraph/core/src/op/mvn.cpp
@blesniewski blesniewski force-pushed the remove_and_fix_ops_part3 branch from 00f080f to 4b4f8e4 Compare December 1, 2020 13:19
@blesniewski blesniewski marked this pull request as ready for review December 1, 2020 15:18
@blesniewski blesniewski requested a review from a team December 1, 2020 15:18
@blesniewski blesniewski added category: IE Tests OpenVINO Test: plugins and common category: Core OpenVINO Core (aka ngraph) labels Dec 1, 2020
@blesniewski blesniewski requested a review from ilyachur December 1, 2020 15:19
Copy link
Copy Markdown
Contributor

@ilyachur ilyachur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve merge conflicts

Comment thread ngraph/core/src/op/mvn.cpp
Comment thread inference-engine/src/readers/ir_reader/ie_ir_parser.cpp Outdated
Copy link
Copy Markdown
Contributor

@ilyachur ilyachur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this PR. But I propose to resolve a nitpick in the next PR

Comment thread ngraph/core/include/ngraph/op/not_equal.hpp
@ilyachur ilyachur merged commit 86347bd into openvinotoolkit:master Dec 8, 2020
@blesniewski blesniewski deleted the remove_and_fix_ops_part3 branch December 8, 2020 11:56
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Dec 11, 2020
…it#3356)

* remove convert op from layer creator

* remove depthtospace op from layer creator

* remove mvn op from layer creator

* remove normalizel2 op from layer creator

* remove notequal op from layer creator

* remove subtract op from layer creator

* correct mvn op behavior when copied with new input

* fix trying to get precision from empty output of normalize layer

* fix normalize layer not setting output type

* remove trailing whitespace

* add fp64 to possible convert op precision types

* use a function to translate bool string representation

* merge emergency opset changes for mvn and roipooling ops
vzinovie pushed a commit to vzinovie/openvino that referenced this pull request Dec 15, 2020
…it#3356)

* remove convert op from layer creator

* remove depthtospace op from layer creator

* remove mvn op from layer creator

* remove normalizel2 op from layer creator

* remove notequal op from layer creator

* remove subtract op from layer creator

* correct mvn op behavior when copied with new input

* fix trying to get precision from empty output of normalize layer

* fix normalize layer not setting output type

* remove trailing whitespace

* add fp64 to possible convert op precision types

* use a function to translate bool string representation

* merge emergency opset changes for mvn and roipooling ops
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Dec 16, 2020
…it#3356)

* remove convert op from layer creator

* remove depthtospace op from layer creator

* remove mvn op from layer creator

* remove normalizel2 op from layer creator

* remove notequal op from layer creator

* remove subtract op from layer creator

* correct mvn op behavior when copied with new input

* fix trying to get precision from empty output of normalize layer

* fix normalize layer not setting output type

* remove trailing whitespace

* add fp64 to possible convert op precision types

* use a function to translate bool string representation

* merge emergency opset changes for mvn and roipooling ops
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Jan 14, 2021
…it#3356)

* remove convert op from layer creator

* remove depthtospace op from layer creator

* remove mvn op from layer creator

* remove normalizel2 op from layer creator

* remove notequal op from layer creator

* remove subtract op from layer creator

* correct mvn op behavior when copied with new input

* fix trying to get precision from empty output of normalize layer

* fix normalize layer not setting output type

* remove trailing whitespace

* add fp64 to possible convert op precision types

* use a function to translate bool string representation

* merge emergency opset changes for mvn and roipooling ops
jiwaszki pushed a commit to akuporos/openvino that referenced this pull request Jan 15, 2021
…it#3356)

* remove convert op from layer creator

* remove depthtospace op from layer creator

* remove mvn op from layer creator

* remove normalizel2 op from layer creator

* remove notequal op from layer creator

* remove subtract op from layer creator

* correct mvn op behavior when copied with new input

* fix trying to get precision from empty output of normalize layer

* fix normalize layer not setting output type

* remove trailing whitespace

* add fp64 to possible convert op precision types

* use a function to translate bool string representation

* merge emergency opset changes for mvn and roipooling ops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: Core OpenVINO Core (aka ngraph) category: IE Tests OpenVINO Test: plugins and common

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants