[GNA] Import/Export memory layer name#3252
Merged
dorloff merged 4 commits intoopenvinotoolkit:masterfrom Feb 24, 2021
Merged
Conversation
bsochack
reviewed
Nov 20, 2020
| for (auto && state : states) { | ||
| writeBits(offsetFromBase(state.first), os); | ||
| writeBits(state.second, os); | ||
| void* gna_ptr; |
Contributor
There was a problem hiding this comment.
always initialize variables
bsochack
approved these changes
Nov 20, 2020
9f5d28d to
087b6a2
Compare
bsochack
reviewed
Nov 23, 2020
| readBits(segmentSz, is); | ||
| uint32_t nameSize = 0; | ||
| readNBits<32>(nameSize, is); | ||
| // std::string inName("", nameSize); |
| writeBits(state.second, os); | ||
| void* gna_ptr = nullptr; | ||
| uint32_t reserved_size = 0; | ||
| std::string name = "noname"; |
Contributor
There was a problem hiding this comment.
There is no point in initializing it with "noname" as it will be overwritten in the next step.
23ef49b to
1166b6a
Compare
755bc2b to
e5aa056
Compare
bsochack
suggested changes
Feb 19, 2021
| writeBits(offsetFromBase(state.first), os); | ||
| writeBits(state.second, os); | ||
| void* gna_ptr = nullptr; | ||
| uint32_t reserved_size; |
Contributor
There was a problem hiding this comment.
Please initialize all variables i.e. reserved_size, scale_factor
| } | ||
| } else { | ||
| readOffset(pSegment, basePointer, is); | ||
| uint32_t segmentSz; |
Contributor
There was a problem hiding this comment.
please initialize all variables except the ones with constructors i.e. strings
| ::testing::ValuesIn(importConfigs)), | ||
| ImportMemoryTest::getTestCaseName); | ||
|
|
||
| } // namespace LayerTestsDefinitions |
Contributor
There was a problem hiding this comment.
Please check if it works for GNA_SW_FP32
Contributor
Author
There was a problem hiding this comment.
No, It's not working for GNA_SW_FP32
Added test Added fix [GNA] Added import/export names of memory layer Added fix test build centOS fix
e5aa056 to
1cb62ad
Compare
493a791 to
0044ed0
Compare
0044ed0 to
9c7e65d
Compare
bsochack
approved these changes
Feb 24, 2021
tadamowicz
pushed a commit
to tadamowicz/openvino
that referenced
this pull request
Aug 30, 2023
* [GNA] Added import/export names of memory layer Added test Added fix [GNA] Added import/export names of memory layer Added fix test build centOS fix * Added fix version * [GNA] Added export/import scale factor for memory layer * [GNA] Fix comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.