Remove ops from Layer Creator/ Node Converter - part 2#3226
Merged
ilyachur merged 39 commits intoopenvinotoolkit:masterfrom Dec 4, 2020
Merged
Remove ops from Layer Creator/ Node Converter - part 2#3226ilyachur merged 39 commits intoopenvinotoolkit:masterfrom
ilyachur merged 39 commits intoopenvinotoolkit:masterfrom
Conversation
…into remove_and_fix_ops_part2
5661485 to
0ae57d2
Compare
0ae57d2 to
3414d9a
Compare
Contributor
Author
|
So far this is just to double-check that all tests are passing, I'll be adding more reviewers when the changes are ready. |
sdurawa
reviewed
Nov 20, 2020
ilyachur
reviewed
Nov 20, 2020
lazarevevgeny
suggested changes
Nov 20, 2020
inference-engine/src/legacy_api/src/convert_function_to_cnn_network.cpp
Outdated
Show resolved
Hide resolved
inference-engine/src/legacy_api/src/convert_function_to_cnn_network.cpp
Outdated
Show resolved
Hide resolved
inference-engine/src/legacy_api/src/convert_function_to_cnn_network.cpp
Outdated
Show resolved
Hide resolved
inference-engine/src/legacy_api/src/ngraph_ops/prior_box_clustered_ie.cpp
Show resolved
Hide resolved
inference-engine/tests/ie_test_utils/functional_test_utils/network_utils.cpp
Outdated
Show resolved
Hide resolved
ilyachur
reviewed
Dec 1, 2020
inference-engine/src/legacy_api/src/convert_function_to_cnn_network.cpp
Outdated
Show resolved
Hide resolved
inference-engine/src/legacy_api/src/convert_function_to_cnn_network.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Ilya Churaev <ilyachur@gmail.com>
Co-authored-by: Ilya Churaev <ilyachur@gmail.com>
…into remove_and_fix_ops_part2
…wski/openvino into remove_and_fix_ops_part2
sdurawa
reviewed
Dec 1, 2020
sdurawa
approved these changes
Dec 1, 2020
ilyachur
reviewed
Dec 2, 2020
inference-engine/src/legacy_api/src/convert_function_to_cnn_network.cpp
Outdated
Show resolved
Hide resolved
ilyachur
approved these changes
Dec 2, 2020
Contributor
Author
|
@lazarevevgeny Could you take a look please? |
lazarevevgeny
approved these changes
Dec 4, 2020
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Dec 11, 2020
…it#3226) * remove power op from layer creator * remove prelu op from layer creator * remove tile op from layer creator * remove relu op from layer creator * remove selu op from layer creator * remove softmax op from layer creator * remove tanh op from layer creator * remove split op from layer creator * remove reshape op from layer creator * remove reverse sequence op from layer creator * remove proposal op from layer creator * remove priorbox op from layer creator * remove roipooling op from layer creator * remove priorboxclustered op from layer creator * style fix * utility function to parse bool-containing strings * align priorbox scale_all_sizes parameter to specification * change location of getBoolStrParamAsIntStr function * align prelu creator to new constant op changes * adjust priorbox tests to align with scale_all_sizes default value * adjust priorbox python tests to align with scale_all_sizes default value * align priorboxclustered attributes initlialization to specification * fix checking wrong container's end iterator for opset name search * improve comment on roipooling parameters * Apply review suggestion 1 Co-authored-by: Ilya Churaev <ilyachur@gmail.com> * Apply review suggestion 2 Co-authored-by: Ilya Churaev <ilyachur@gmail.com> * align priorbox step initial value to specification * align roipooling method attribute to specification * remove roipooling specific creator * align with review comments Co-authored-by: Ilya Churaev <ilyachur@gmail.com>
vzinovie
pushed a commit
to vzinovie/openvino
that referenced
this pull request
Dec 15, 2020
…it#3226) * remove power op from layer creator * remove prelu op from layer creator * remove tile op from layer creator * remove relu op from layer creator * remove selu op from layer creator * remove softmax op from layer creator * remove tanh op from layer creator * remove split op from layer creator * remove reshape op from layer creator * remove reverse sequence op from layer creator * remove proposal op from layer creator * remove priorbox op from layer creator * remove roipooling op from layer creator * remove priorboxclustered op from layer creator * style fix * utility function to parse bool-containing strings * align priorbox scale_all_sizes parameter to specification * change location of getBoolStrParamAsIntStr function * align prelu creator to new constant op changes * adjust priorbox tests to align with scale_all_sizes default value * adjust priorbox python tests to align with scale_all_sizes default value * align priorboxclustered attributes initlialization to specification * fix checking wrong container's end iterator for opset name search * improve comment on roipooling parameters * Apply review suggestion 1 Co-authored-by: Ilya Churaev <ilyachur@gmail.com> * Apply review suggestion 2 Co-authored-by: Ilya Churaev <ilyachur@gmail.com> * align priorbox step initial value to specification * align roipooling method attribute to specification * remove roipooling specific creator * align with review comments Co-authored-by: Ilya Churaev <ilyachur@gmail.com>
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Dec 16, 2020
…it#3226) * remove power op from layer creator * remove prelu op from layer creator * remove tile op from layer creator * remove relu op from layer creator * remove selu op from layer creator * remove softmax op from layer creator * remove tanh op from layer creator * remove split op from layer creator * remove reshape op from layer creator * remove reverse sequence op from layer creator * remove proposal op from layer creator * remove priorbox op from layer creator * remove roipooling op from layer creator * remove priorboxclustered op from layer creator * style fix * utility function to parse bool-containing strings * align priorbox scale_all_sizes parameter to specification * change location of getBoolStrParamAsIntStr function * align prelu creator to new constant op changes * adjust priorbox tests to align with scale_all_sizes default value * adjust priorbox python tests to align with scale_all_sizes default value * align priorboxclustered attributes initlialization to specification * fix checking wrong container's end iterator for opset name search * improve comment on roipooling parameters * Apply review suggestion 1 Co-authored-by: Ilya Churaev <ilyachur@gmail.com> * Apply review suggestion 2 Co-authored-by: Ilya Churaev <ilyachur@gmail.com> * align priorbox step initial value to specification * align roipooling method attribute to specification * remove roipooling specific creator * align with review comments Co-authored-by: Ilya Churaev <ilyachur@gmail.com>
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Jan 14, 2021
…it#3226) * remove power op from layer creator * remove prelu op from layer creator * remove tile op from layer creator * remove relu op from layer creator * remove selu op from layer creator * remove softmax op from layer creator * remove tanh op from layer creator * remove split op from layer creator * remove reshape op from layer creator * remove reverse sequence op from layer creator * remove proposal op from layer creator * remove priorbox op from layer creator * remove roipooling op from layer creator * remove priorboxclustered op from layer creator * style fix * utility function to parse bool-containing strings * align priorbox scale_all_sizes parameter to specification * change location of getBoolStrParamAsIntStr function * align prelu creator to new constant op changes * adjust priorbox tests to align with scale_all_sizes default value * adjust priorbox python tests to align with scale_all_sizes default value * align priorboxclustered attributes initlialization to specification * fix checking wrong container's end iterator for opset name search * improve comment on roipooling parameters * Apply review suggestion 1 Co-authored-by: Ilya Churaev <ilyachur@gmail.com> * Apply review suggestion 2 Co-authored-by: Ilya Churaev <ilyachur@gmail.com> * align priorbox step initial value to specification * align roipooling method attribute to specification * remove roipooling specific creator * align with review comments Co-authored-by: Ilya Churaev <ilyachur@gmail.com>
jiwaszki
pushed a commit
to akuporos/openvino
that referenced
this pull request
Jan 15, 2021
…it#3226) * remove power op from layer creator * remove prelu op from layer creator * remove tile op from layer creator * remove relu op from layer creator * remove selu op from layer creator * remove softmax op from layer creator * remove tanh op from layer creator * remove split op from layer creator * remove reshape op from layer creator * remove reverse sequence op from layer creator * remove proposal op from layer creator * remove priorbox op from layer creator * remove roipooling op from layer creator * remove priorboxclustered op from layer creator * style fix * utility function to parse bool-containing strings * align priorbox scale_all_sizes parameter to specification * change location of getBoolStrParamAsIntStr function * align prelu creator to new constant op changes * adjust priorbox tests to align with scale_all_sizes default value * adjust priorbox python tests to align with scale_all_sizes default value * align priorboxclustered attributes initlialization to specification * fix checking wrong container's end iterator for opset name search * improve comment on roipooling parameters * Apply review suggestion 1 Co-authored-by: Ilya Churaev <ilyachur@gmail.com> * Apply review suggestion 2 Co-authored-by: Ilya Churaev <ilyachur@gmail.com> * align priorbox step initial value to specification * align roipooling method attribute to specification * remove roipooling specific creator * align with review comments Co-authored-by: Ilya Churaev <ilyachur@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing ops from layer creator:
41390