Skip to content

Provide GatherND with original layout for inputs and output#3002

Merged
lazarevevgeny merged 2 commits intoopenvinotoolkit:masterfrom
rkazants:fix/rkazants/41818_gathernd
Nov 10, 2020
Merged

Provide GatherND with original layout for inputs and output#3002
lazarevevgeny merged 2 commits intoopenvinotoolkit:masterfrom
rkazants:fix/rkazants/41818_gathernd

Conversation

@rkazants
Copy link
Copy Markdown
Collaborator

@rkazants rkazants commented Nov 6, 2020 •
edited
Loading

Description: GatherND accepts inputs and output in NHWC layout in case TensorFlow so implemented transformation cares of it.

JIRA: 41818

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR
  • Transformation preserves original framework node names

Validation:

  • Unit tests
  • Framework operation tests - N/A
  • Transformation tests
  • e2e model test with an update of ./tests/e2e_oss/utils/reshape_utils.py - N/A
  • Model Optimizer IR Reader check

Documentation:

  • Supported frameworks operations list
  • Supported public models list - N/A
  • New operations specification
  • Guide on how to convert the public model - N/A
  • User guide update - N/A

Signed-off-by: Roman Kazantsev roman.kazantsev@intel.com

@rkazants rkazants requested review from a team and lazarevevgeny November 6, 2020 09:33
@openvino-pushbot openvino-pushbot added the category: MO Model Optimizer label Nov 6, 2020
lazarevevgeny
lazarevevgeny suggested changes Nov 6, 2020
View reviewed changes
@lazarevevgeny lazarevevgeny self-assigned this Nov 6, 2020
@rkazants rkazants force-pushed the fix/rkazants/41818_gathernd branch from 1657502 to f97f985 Compare November 9, 2020 07:44
@rkazants rkazants force-pushed the fix/rkazants/41818_gathernd branch from f97f985 to 9b0514e Compare November 9, 2020 09:35
@lazarevevgeny
Copy link
Copy Markdown
Contributor

lazarevevgeny commented Nov 9, 2020

@rkazants, please, pick up changes from the recent master to pass OpenVINO-ONNX job

@rkazants rkazants force-pushed the fix/rkazants/41818_gathernd branch from 9b0514e to c08c623 Compare November 10, 2020 07:34
@rkazants
Provide GatherND with original layout for inputs and output
c7b8578 
Signed-off-by: Roman Kazantsev <roman.kazantsev@intel.com>
@rkazants
Fix code review #1
f9dba7c 
Signed-off-by: Roman Kazantsev <roman.kazantsev@intel.com>
@rkazants rkazants force-pushed the fix/rkazants/41818_gathernd branch from c08c623 to f9dba7c Compare November 10, 2020 09:21
@lazarevevgeny lazarevevgeny merged commit e3b879a into openvinotoolkit:master Nov 10, 2020
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Dec 16, 2020
@rkazants @mryzhov
Provide GatherND with original layout for inputs and output (openvino…
5c4a6a8 
…toolkit#3002)

* Provide GatherND with original layout for inputs and output

Signed-off-by: Roman Kazantsev <roman.kazantsev@intel.com>

* Fix code review #1

Signed-off-by: Roman Kazantsev <roman.kazantsev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lazarevevgeny lazarevevgeny lazarevevgeny approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lazarevevgeny lazarevevgeny

Labels

category: MO Model Optimizer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rkazants @lazarevevgeny @openvino-pushbot