Reference implementations for Loop and TensorIterator ops#2978
Merged
ilyachur merged 80 commits intoopenvinotoolkit:masterfrom Nov 10, 2020
Merged
Reference implementations for Loop and TensorIterator ops#2978ilyachur merged 80 commits intoopenvinotoolkit:masterfrom
ilyachur merged 80 commits intoopenvinotoolkit:masterfrom
Conversation
…sable single layer tests
ilyachur
reviewed
Nov 6, 2020
iefode
approved these changes
Nov 6, 2020
Contributor
iefode
left a comment
There was a problem hiding this comment.
One more comment, it will be good to add TI single layer tests
mbencer
suggested changes
Nov 9, 2020
ilyachur
reviewed
Nov 9, 2020
ngraph/core/reference/include/ngraph/runtime/reference/function.hpp
Outdated
Show resolved
Hide resolved
AlexPeskov
approved these changes
Nov 9, 2020
...ne/tests/functional/plugin/cpu/shared_tests_instances/single_layer_tests/tensor_iterator.cpp
Outdated
Show resolved
Hide resolved
inference-engine/tests/functional/plugin/shared/include/single_layer_tests/loop.hpp
Show resolved
Hide resolved
ngraph/core/reference/include/ngraph/runtime/reference/function.hpp
Outdated
Show resolved
Hide resolved
mbencer
approved these changes
Nov 9, 2020
iefode
reviewed
Nov 9, 2020
inference-engine/tests/functional/plugin/shared/include/single_layer_tests/tensor_iterator.hpp
Outdated
Show resolved
Hide resolved
inference-engine/tests/functional/plugin/shared/include/single_layer_tests/tensor_iterator.hpp
Show resolved
Hide resolved
inference-engine/tests/functional/plugin/shared/src/single_layer_tests/loop.cpp
Outdated
Show resolved
Hide resolved
inference-engine/tests/functional/plugin/shared/src/single_layer_tests/loop.cpp
Outdated
Show resolved
Hide resolved
inference-engine/tests/functional/plugin/shared/src/single_layer_tests/tensor_iterator.cpp
Outdated
Show resolved
Hide resolved
inference-engine/tests/functional/plugin/shared/src/single_layer_tests/tensor_iterator.cpp
Show resolved
Hide resolved
inference-engine/tests/functional/plugin/shared/src/single_layer_tests/tensor_iterator.cpp
Show resolved
Hide resolved
inference-engine/tests/functional/plugin/shared/src/single_layer_tests/loop.cpp
Show resolved
Hide resolved
ilyachur
approved these changes
Nov 10, 2020
ngraph/core/reference/include/ngraph/runtime/reference/function.hpp
Outdated
Show resolved
Hide resolved
ngraph/core/reference/include/ngraph/runtime/reference/function.hpp
Outdated
Show resolved
Hide resolved
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Dec 16, 2020
…olkit#2978) * Loop op ngraph implementation, update IE IR Reader and ngraph to cnn converter * refactoring SubGraphOp class * type prop unit tests * ngraph code style * update comment * single layer tests for Loop operation * fix file name * Add SpecialBodyPorts attribute in Loop op, update single layer tests * first debug version * more tests * missing test file * removed not needed shapes from test data * move test data to new folder * shape infer tests * Added execution tests * add several new tests cases, strict checks in Loop impl, temporary disable single layer tests * ngraph codestyle, refactoring, clone_new_args test * resolve review remarks * fix build * fix tests * more execution tests * add a new constructor of Loop op, resolve review remarks * execution tests * synchro with current version * handle scalars and more tests * scalar test enabled * loop reference impl * bug fixes in tests, onnx importer part and in the ref implementation of the Loop op * applied remarks * handle unsupported cases * rewrite unit tests * update INTERPRETER manifest * is_termination_condition_always_true simplification * [TEST] update python models tests * review remarks * added xfail to tiny_yolov3 * missing model test * revert test data * fixed numbers of failing tests * fixed failed test description * fix test message * fix xfail test * reference implementation for ngraph::function * update loop reference implementation * Refactor loop reference implementation * ngraph codestyle * Refactoring * Submodule update * Skip check for Reduce ops in mkl for scalar cases, support for yolov3 * fix ngraph reader tests * revert ceiling op, renaming * Add allias(Ceiling) for Ceil op in mkl * delete xfails * fix build * single layer tests for tensor iterarator * Refactor TensorIterator and Loop ref impls * revert dynamic tensor creation, disable some dynamic test cases * fix warning * Resolve review remarks * revert Predefined values in Loop tests Co-authored-by: Mateusz Bencer <mateusz.bencer@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc: fixes (Reduce 1d cases in mkl, Ceiling naming in mkl), refactoring