Skip to content

[GNA] fixed case when input connected to concat from left and const from right#2874

Merged
dorloff merged 4 commits intoopenvinotoolkit:masterfrom
admitriev-gna:feature/ad/first_input_connect
Nov 10, 2020
Merged

[GNA] fixed case when input connected to concat from left and const from right#2874
dorloff merged 4 commits intoopenvinotoolkit:masterfrom
admitriev-gna:feature/ad/first_input_connect

Conversation

@admitriev-gna
Copy link
Copy Markdown
Contributor

No description provided.

@admitriev-gna admitriev-gna added the category: GNA OpenVINO GNA plugin label Oct 28, 2020
@admitriev-gna admitriev-gna self-assigned this Oct 28, 2020
@admitriev-gna admitriev-gna force-pushed the feature/ad/first_input_connect branch from af87aff to 3a64ca4 Compare October 28, 2020 12:16
@admitriev-gna admitriev-gna force-pushed the feature/ad/first_input_connect branch 5 times, most recently from f169d4b to 0351f93 Compare November 2, 2020 10:22
@bsochack
Copy link
Copy Markdown
Contributor

bsochack commented Nov 2, 2020

looks good

@admitriev-gna admitriev-gna marked this pull request as ready for review November 2, 2020 11:31
@admitriev-gna admitriev-gna requested review from a team November 2, 2020 11:31
@admitriev-gna admitriev-gna force-pushed the feature/ad/first_input_connect branch 5 times, most recently from b42dd7a to 50ab98f Compare November 3, 2020 13:44
@@ -2141,7 +2141,7 @@ GNAPluginNS::ConnectionDetails GNAGraphCompiler::connectInput(CNNLayerPtr layer,
auto memorySize = InferenceEngine::details::product(memoryLayer.getDims()) * memoryLayer.elementSizeBytes();

// negative offset used for indicate that memory layer should be bound to given buffer
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please correct a comment as it is not correct

@admitriev-gna admitriev-gna force-pushed the feature/ad/first_input_connect branch 3 times, most recently from a77507b to a86ca9b Compare November 6, 2020 08:03
@admitriev-gna admitriev-gna force-pushed the feature/ad/first_input_connect branch from a86ca9b to dd24d49 Compare November 6, 2020 10:05
@dorloff dorloff merged commit 4a0170d into openvinotoolkit:master Nov 10, 2020
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Dec 16, 2020
…rom right (openvinotoolkit#2874)

* Added test

* Added fix

* Fix comment

* Fix conflict
tadamowicz pushed a commit to tadamowicz/openvino that referenced this pull request Aug 30, 2023
…rom right (openvinotoolkit#2874)

* Added test

* Added fix

* Fix comment

* Fix conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: GNA OpenVINO GNA plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants