Skip to content

[IE CLDNN] Plugin-side kernels caching#2871

Merged
vladimir-paramuzov merged 5 commits intoopenvinotoolkit:masterfrom
vladimir-paramuzov:cache_poc
Nov 5, 2020
Merged

[IE CLDNN] Plugin-side kernels caching#2871
vladimir-paramuzov merged 5 commits intoopenvinotoolkit:masterfrom
vladimir-paramuzov:cache_poc

Conversation

@vladimir-paramuzov
Copy link
Copy Markdown

@vladimir-paramuzov vladimir-paramuzov commented Oct 28, 2020

  • Added plugin key to enable kernels caching and added plugin-side mechanism to do it.

@vladimir-paramuzov vladimir-paramuzov added the category: GPU OpenVINO GPU plugin label Oct 28, 2020
ilya-lavrenov
ilya-lavrenov reviewed Oct 28, 2020
View reviewed changes
@vladimir-paramuzov vladimir-paramuzov force-pushed the cache_poc branch 3 times, most recently from 4be612f to 5aa41dc Compare October 29, 2020 06:50
@vladimir-paramuzov vladimir-paramuzov marked this pull request as ready for review October 29, 2020 10:07
@vladimir-paramuzov vladimir-paramuzov requested review from a team as code owners October 29, 2020 10:07
@vladimir-paramuzov vladimir-paramuzov requested a review from a team October 29, 2020 10:07
@vladimir-paramuzov vladimir-paramuzov changed the title [WIP] [IE CLDNN] Plugin-side kernels caching POC [IE CLDNN] Plugin-side kernels caching Oct 29, 2020
@JulienMaille
Copy link
Copy Markdown

JulienMaille commented Oct 31, 2020

How is this going to work if we have openCL cl_cache folder mechanism already enabled?

@vladimir-paramuzov
Copy link
Copy Markdown
Author

vladimir-paramuzov commented Nov 2, 2020

How is this going to work if we have openCL cl_cache folder mechanism already enabled?

If cl_cache is enabled as well, then:

  • compiled binaries will be dumped twice
  • if a kernel is found in plugin's cache on load stage, then cl_cache is not used for this kernel

ilya-lavrenov
ilya-lavrenov reviewed Nov 2, 2020
View reviewed changes
@vladimir-paramuzov
Copy link
Copy Markdown
Author

vladimir-paramuzov commented Nov 3, 2020

@iefode please have a look at the tests and test utils

iefode
iefode reviewed Nov 3, 2020
View reviewed changes
@alalek alalek mentioned this pull request Nov 3, 2020
Closed
@vladimir-paramuzov vladimir-paramuzov requested a review from a team November 3, 2020 17:12
@vladimir-paramuzov vladimir-paramuzov added this to the 2021.2 milestone Nov 4, 2020
sshlyapn
sshlyapn approved these changes Nov 5, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@sshlyapn sshlyapn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vladimir-paramuzov vladimir-paramuzov merged commit 6e7db6f into openvinotoolkit:master Nov 5, 2020
@vladimir-paramuzov vladimir-paramuzov deleted the cache_poc branch November 5, 2020 20:44
sdurawa pushed a commit to sdurawa/openvino that referenced this pull request Nov 6, 2020
@sdurawa
[IE CLDNN] Plugin-side kernels caching (openvinotoolkit#2871)
cd45781
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Dec 16, 2020
@mryzhov
[IE CLDNN] Plugin-side kernels caching (openvinotoolkit#2871)
8ddd96d
@alalek alalek mentioned this pull request Apr 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@sshlyapn sshlyapn sshlyapn approved these changes

@iefode iefode iefode approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mletavin mletavin

@sshlyapn sshlyapn

Labels

category: GPU OpenVINO GPU plugin

Projects

None yet

Milestone

2021.2

Development

Successfully merging this pull request may close these issues.

6 participants

@vladimir-paramuzov @JulienMaille @ilya-lavrenov @sshlyapn @iefode @mletavin