Revise Broadcast reference implementation#2715
Merged
GlebKazantaev merged 42 commits intoopenvinotoolkit:masterfrom Nov 10, 2020
Merged
Revise Broadcast reference implementation#2715GlebKazantaev merged 42 commits intoopenvinotoolkit:masterfrom
GlebKazantaev merged 42 commits intoopenvinotoolkit:masterfrom
Conversation
…Change input_rank to be constant int
ilyachur
reviewed
Oct 19, 2020
added 2 commits
October 20, 2020 13:53
postrational
approved these changes
Oct 27, 2020
added 4 commits
October 28, 2020 12:17
ilyachur
reviewed
Oct 29, 2020
|
|
||
| // Copy and repeat data for innermost axis as many times as described in the repeats parameter | ||
| while (axis <= indices.size()) | ||
| try |
Contributor
There was a problem hiding this comment.
Could you explain why you added this try/catch and changed the Tile code?
Should we add more tests for Tile op?
Contributor
Author
There was a problem hiding this comment.
added 4 commits
October 29, 2020 08:11
GlebKazantaev
approved these changes
Oct 29, 2020
ilyachur
approved these changes
Oct 30, 2020
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Dec 16, 2020
* change tile reference implementation * remove tile tests from interpreter manifest * add repeats parameter to tile * improve tile reference implementation * add repeats parameter to tile reference call in tile evaluate method * style apply * include <numeric> * add unnamed namespace to helper functions. Change stdio.h to cstdio. Change input_rank to be constant int * add const reference to parameter repeats in tile reference function * change createPitches function to use partial_sum instead of accumulate * change a little bit createPitches function * style-apply * fix function naming * style-apply * fix calling functions name bug * Add description of create_pitches function * first version with debug logs * reduce footprint * single layer tests * added more tests * fixed handling bool type * styles applied * fix tile * [ONLY DEBUG] print error scenario message * fixed problem with e2e tests * fixed casting of start_axis for numpy mode Co-authored-by: pszmel <piotr.szmelczynski@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #2641 (tile reference implementation) which should be merged first.