Skip to content

[VPU][IE] Disable ConvertMinimum transformation for Myriad Plugin#2437

Merged
ilyachur merged 1 commit intomasterfrom
unknown repository
Oct 5, 2020
Merged

[VPU][IE] Disable ConvertMinimum transformation for Myriad Plugin#2437
ilyachur merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Sep 28, 2020

Ticket - #-38650
Disable Minimum to Power & Maximum decomposition, because it's actually not needed (Minimum is supported both for FP16 and I32) and it also breaks the dynamism in the current pipeline.

@ghost ghost added category: inference OpenVINO Runtime library - Inference category: VPU labels Sep 28, 2020
@ghost ghost added this to the 2021.2 milestone Sep 28, 2020
@ghost ghost self-assigned this Sep 28, 2020
@ghost ghost marked this pull request as ready for review September 30, 2020 10:35
@ghost ghost requested review from a team, GlebKazantaev and ilyachur as code owners September 30, 2020 10:35
@ghost ghost requested review from a team and andrejsokolov September 30, 2020 10:35
@ghost ghost assigned ilyachur, andrejsokolov and ghost Oct 1, 2020
@ghost
Copy link
Copy Markdown
Author

ghost commented Oct 1, 2020

@elatkin @andrejsokolov could you please take a look?
@ilyachur could you please take a look at the common part? I don't think it's actually needed to prohibit the creation of Eltwise Minimum because some of the plugins may really want to receive the Minimum layer instead of its decomposition.

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndrewBakalinIntel
Could you please rebase your branch on fresh OpenVINO/master?
IE-MDK crashes on LSTMCell, maybe needs #2423 merged recently

@ghost
Copy link
Copy Markdown
Author

ghost commented Oct 1, 2020

@AndrewBakalinIntel
Could you please rebase your branch on fresh OpenVINO/master?
IE-MDK crashes on LSTMCell, maybe needs #2423 merged recently

Thanks! Done.

@ghost ghost self-requested a review October 2, 2020 10:11
@ghost
Copy link
Copy Markdown
Author

ghost commented Oct 5, 2020

@andrejsokolov @ilyachur ping

Copy link
Copy Markdown
Contributor

@ilyachur ilyachur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilyachur ilyachur merged commit f8fdd80 into openvinotoolkit:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: inference OpenVINO Runtime library - Inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants