Skip to content

Add HSigmoid spec#2412

Merged
lazarevevgeny merged 4 commits intoopenvinotoolkit:masterfrom
iimironov:imironov/CVS-29571-hsigmoid-spec
Oct 7, 2020
Merged

Add HSigmoid spec#2412
lazarevevgeny merged 4 commits intoopenvinotoolkit:masterfrom
iimironov:imironov/CVS-29571-hsigmoid-spec

Conversation

@iimironov
Copy link
Copy Markdown
Contributor

@iimironov iimironov commented Sep 24, 2020

No description provided.

@iimironov iimironov requested a review from rkazants September 24, 2020 13:33
@iimironov iimironov requested a review from a team as a code owner September 24, 2020 13:33
@openvino-pushbot openvino-pushbot added the category: docs OpenVINO documentation label Sep 24, 2020
nikita-kud
nikita-kud reviewed Sep 24, 2020
View reviewed changes
Comment thread docs/ops/activation/HSigmoid_5.md Outdated
Comment thread docs/ops/activation/HSigmoid_5.md Outdated
rkazants
rkazants reviewed Sep 25, 2020
View reviewed changes
Comment thread docs/ops/activation/HSigmoid_5.md
Comment thread docs/ops/activation/HSigmoid_5.md
Comment thread docs/ops/activation/HSigmoid_5.md
rkazants
rkazants reviewed Sep 25, 2020
View reviewed changes
Comment thread docs/ops/activation/HSigmoid_5.md
rkazants
rkazants reviewed Sep 25, 2020
View reviewed changes
Comment thread docs/ops/activation/HSigmoid_5.md Outdated
rkazants
rkazants requested changes Sep 25, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at comments.

rkazants
rkazants reviewed Sep 25, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HSigmoid is correct. I was wrong about HardSigmoid

@rkazants rkazants self-requested a review September 25, 2020 17:41
@iimironov iimironov force-pushed the imironov/CVS-29571-hsigmoid-spec branch from 245ab3a to a8a52fc Compare September 28, 2020 10:11
@iimironov iimironov force-pushed the imironov/CVS-29571-hsigmoid-spec branch from d0f90dc to 40eb90e Compare October 1, 2020 10:19
postrational
postrational suggested changes Oct 6, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@postrational postrational left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ONNX HardSigmoid uses two parameters alpha and beta according to the following formula: y = max(0, min(1, alpha * x + beta))

We should allow the formula to be parametrised if we want to be able to represent the ONNX operation.

More information: https://github.com/onnx/onnx/blob/master/docs/Operators.md#HardSigmoid

@iimironov
Copy link
Copy Markdown
Contributor Author

iimironov commented Oct 6, 2020

The ONNX HardSigmoid uses two parameters alpha and beta according to the following formula: y = max(0, min(1, alpha * x + beta))

We should allow the formula to be parametrised if we want to be able to represent the ONNX operation.

More information: https://github.com/onnx/onnx/blob/master/docs/Operators.md#HardSigmoid

HardSigmoid not equal HSigmoid.
We already support HardSigmoid. It other operation.

lazarevevgeny
lazarevevgeny suggested changes Oct 6, 2020
View reviewed changes
Comment thread docs/ops/opset5.md
@iimironov iimironov force-pushed the imironov/CVS-29571-hsigmoid-spec branch from 386b182 to 4f99e12 Compare October 6, 2020 13:12
@lazarevevgeny lazarevevgeny merged commit 43dc605 into openvinotoolkit:master Oct 7, 2020
asomsiko pushed a commit to asomsiko/openvino that referenced this pull request Oct 13, 2020
@iimironov
Add HSigmoid spec (openvinotoolkit#2412)
f66d169 
* Add HSigmoid spec
@iimironov iimironov mentioned this pull request Oct 23, 2020
Merged
14 tasks
@iimironov iimironov mentioned this pull request Nov 17, 2020
Merged
14 tasks
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Dec 16, 2020
@iimironov @mryzhov
Add HSigmoid spec (openvinotoolkit#2412)
22a677c 
* Add HSigmoid spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rkazants rkazants rkazants approved these changes

@nikita-kud nikita-kud nikita-kud approved these changes

@vladimir-paramuzov vladimir-paramuzov Awaiting requested review from vladimir-paramuzov

@taka-no-me taka-no-me Awaiting requested review from taka-no-me

@dmitry-gorokhov dmitry-gorokhov Awaiting requested review from dmitry-gorokhov

@esmirno esmirno Awaiting requested review from esmirno

@rzubarev rzubarev Awaiting requested review from rzubarev

@andrew-zaytsev andrew-zaytsev Awaiting requested review from andrew-zaytsev

@dorloff dorloff Awaiting requested review from dorloff

@mitruska mitruska Awaiting requested review from mitruska

+2 more reviewers

@postrational postrational postrational approved these changes

@lazarevevgeny lazarevevgeny lazarevevgeny approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

category: docs OpenVINO documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@iimironov @postrational @mitruska @lazarevevgeny @rkazants @nikita-kud @openvino-pushbot