Skip to content

interpolate ops improvement#2366

Merged
dmitry-gorokhov merged 14 commits intoopenvinotoolkit:masterfrom
chenhu-wang:chenhu/opt_for_interpolate-4
Nov 17, 2020
Merged

interpolate ops improvement#2366
dmitry-gorokhov merged 14 commits intoopenvinotoolkit:masterfrom
chenhu-wang:chenhu/opt_for_interpolate-4

Conversation

@chenhu-wang
Copy link
Copy Markdown
Contributor

@chenhu-wang chenhu-wang commented Sep 22, 2020 •
edited
Loading

  1. CVS-40771: JITTED cubic mode for interpolation layer
  2. CVS-39017: Interpolate-4 fails tests using NHWC mem order with padding
  3. Align the fix of onnx-runtime issue for resize op: "Resize-11" ops with "nearest neighbour" mode have unexpected behavior microsoft/onnxruntime#5151
  4. CVS-40772: transform interpolate-1 to interpolate-4, to enable infer interplate1 layer generated by old version OV with interpolate4 implementation in mkldnn plugin.( interpolateToLegacy transformation is registered as true by default, interpolateToInterpolate4 is registered as false by default. In mkldnn plugin, interpolateToLegacy is disabled and interpolateToInterpolate4 is enable. Such that other plugins do not implemented interpolate4 can still transform to and infer with legacy implementation)

@chenhu-wang chenhu-wang added the category: CPU OpenVINO CPU plugin label Sep 22, 2020
@chenhu-wang chenhu-wang added this to the 2021.2 milestone Sep 22, 2020
@chenhu-wang chenhu-wang requested review from a team September 22, 2020 08:42
@openvino-pushbot openvino-pushbot added category: IE Tests OpenVINO Test: plugins and common category: Core OpenVINO Core (aka ngraph) labels Sep 22, 2020
@chenhu-wang chenhu-wang force-pushed the chenhu/opt_for_interpolate-4 branch 2 times, most recently from 04987be to 5109a30 Compare September 22, 2020 09:03
@chenhu-wang chenhu-wang changed the title interpolate ops improvement [WIP]interpolate ops improvement Sep 22, 2020
@chenhu-wang chenhu-wang force-pushed the chenhu/opt_for_interpolate-4 branch 3 times, most recently from 93e6f27 to 6e84e6f Compare September 24, 2020 06:57
@GlebKazantaev GlebKazantaev removed the request for review from a team September 24, 2020 08:28
@chenhu-wang chenhu-wang force-pushed the chenhu/opt_for_interpolate-4 branch 4 times, most recently from 1e2926c to b5607cc Compare October 14, 2020 05:57
@chenhu-wang chenhu-wang changed the title [WIP]interpolate ops improvement interpolate ops improvement Oct 14, 2020
@chenhu-wang chenhu-wang force-pushed the chenhu/opt_for_interpolate-4 branch 3 times, most recently from ce271b0 to 5df9f94 Compare October 16, 2020 01:12
lazarevevgeny
lazarevevgeny approved these changes Oct 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lazarevevgeny lazarevevgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the nGraph changed part.

@dmitry-gorokhov dmitry-gorokhov self-assigned this Oct 26, 2020
@chenhu-wang chenhu-wang force-pushed the chenhu/opt_for_interpolate-4 branch from 5df9f94 to 701155f Compare October 27, 2020 03:28
@chenhu-wang chenhu-wang force-pushed the chenhu/opt_for_interpolate-4 branch from 701155f to 58a2b14 Compare October 27, 2020 03:34
@dmitry-gorokhov
Copy link
Copy Markdown

dmitry-gorokhov commented Nov 9, 2020

@GlebKazantaev Could you please re-review transformations part?

@chenhu-wang chenhu-wang force-pushed the chenhu/opt_for_interpolate-4 branch 4 times, most recently from 9066e29 to eebd266 Compare November 12, 2020 08:57
@dmitry-gorokhov dmitry-gorokhov mentioned this pull request Nov 13, 2020
Merged
@chenhu-wang chenhu-wang force-pushed the chenhu/opt_for_interpolate-4 branch 3 times, most recently from 84cfa8a to 27dc0be Compare November 16, 2020 11:28
@chenhu-wang chenhu-wang force-pushed the chenhu/opt_for_interpolate-4 branch from 27dc0be to bf6f019 Compare November 16, 2020 12:18
@chenhu-wang chenhu-wang mentioned this pull request Nov 17, 2020
Merged
@dmitry-gorokhov dmitry-gorokhov merged commit be044a7 into openvinotoolkit:master Nov 17, 2020
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Nov 17, 2020
@chenhu-wang @mryzhov
[CPU] Interpolate operation improvements (openvinotoolkit#2366)
b7f34bc 
* interpolate improvement

* JITTED cubic mode

* fix 'code is too big' when JIT

* extend test to cover tail code path

* transformation of interpolate1 to interpolate4

* add low precision transformation for interpolate4
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Dec 16, 2020
@chenhu-wang @mryzhov
[CPU] Interpolate operation improvements (openvinotoolkit#2366)
97f2334 
* interpolate improvement

* JITTED cubic mode

* fix 'code is too big' when JIT

* extend test to cover tail code path

* transformation of interpolate1 to interpolate4

* add low precision transformation for interpolate4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

@ilyachur ilyachur ilyachur approved these changes

@GlebKazantaev GlebKazantaev GlebKazantaev approved these changes

@lazarevevgeny lazarevevgeny lazarevevgeny approved these changes

@eshoguli eshoguli eshoguli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dmitry-gorokhov dmitry-gorokhov

Labels

category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common

Projects

None yet

Milestone

2021.2

Development

Successfully merging this pull request may close these issues.

7 participants

@chenhu-wang @dmitry-gorokhov @lazarevevgeny @ilyachur @GlebKazantaev @eshoguli @openvino-pushbot