Implement LookupTableInsert shape inference#2348
Merged
lazarevevgeny merged 4 commits intoopenvinotoolkit:masterfrom Oct 20, 2020
Merged
Implement LookupTableInsert shape inference#2348lazarevevgeny merged 4 commits intoopenvinotoolkit:masterfrom
lazarevevgeny merged 4 commits intoopenvinotoolkit:masterfrom
Conversation
e-nugmanova
reviewed
Sep 21, 2020
939dbb2 to
657d981
Compare
mvafin
approved these changes
Sep 22, 2020
achetver
approved these changes
Sep 22, 2020
Contributor
achetver
left a comment
There was a problem hiding this comment.
These changes looks good to me.
e-nugmanova
suggested changes
Sep 23, 2020
lazarevevgeny
suggested changes
Oct 7, 2020
Contributor
|
@rkazants , do you plan to resolve these comments? |
657d981 to
85edab4
Compare
It is needed if other nodes not beeing pruned in the graph have a conditional dependence on LookupTableInsertV2 node. Signed-off-by: Roman Kazantsev <roman.kazantsev@intel.com>
Signed-off-by: Roman Kazantsev <roman.kazantsev@intel.com>
Signed-off-by: Roman Kazantsev <roman.kazantsev@intel.com>
d7129ae to
301b6cd
Compare
Collaborator
Author
Resolved. |
lazarevevgeny
suggested changes
Oct 19, 2020
e-nugmanova
approved these changes
Oct 19, 2020
lazarevevgeny
approved these changes
Oct 20, 2020
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Dec 16, 2020
* Implement LookupTableInsertV2 shape inference It is needed if other nodes not beeing pruned in the graph have a conditional dependence on LookupTableInsertV2 node. Signed-off-by: Roman Kazantsev <roman.kazantsev@intel.com> * Fix after core-review #1 Signed-off-by: Roman Kazantsev <roman.kazantsev@intel.com> * Fix the code after review #2 Signed-off-by: Roman Kazantsev <roman.kazantsev@intel.com> * Fix after code review #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: In some OCR model Nodes not being pruned in a graph have a conditional dependence on LookupTableInsert node and it requires a shape inference for this node before conditional resolving pass.
JIRA: 38082
Code:
Validation:
Documentation:
Signed-off-by: Roman Kazantsev roman.kazantsev@intel.com