MKLDNN nodes factory improvements#2252
Merged
dmitry-gorokhov merged 1 commit intoopenvinotoolkit:masterfrom Sep 30, 2020
Merged
MKLDNN nodes factory improvements#2252dmitry-gorokhov merged 1 commit intoopenvinotoolkit:masterfrom
dmitry-gorokhov merged 1 commit intoopenvinotoolkit:masterfrom
Conversation
1d8f7f9 to
468083a
Compare
| return getType() == TensorIterator; | ||
| } | ||
| REG_MKLDNN_PRIM_FOR(MKLDNNTensorIteratorNode, TensorIterator); | ||
| REG_MKLDNN_PRIM_FOR(MKLDNNTensorIteratorNode, MKLDNNPlugin::TensorIterator); |
There was a problem hiding this comment.
Just wondering why do we need MKLDNNPlugin:: here
Contributor
Author
There was a problem hiding this comment.
Without explicit namespace it clashes with TensorIterator from inference-engine/src/legacy_api/include/legacy/ie_layers.h.
Contributor
There was a problem hiding this comment.
maybe it's better to remove global using namespace InferenceEngine?
|
@ilyachur could you please take a look as well? |
82dab25 to
22e924c
Compare
dmitry-gorokhov
approved these changes
Sep 24, 2020
22e924c to
1e4491d
Compare
asomsiko
pushed a commit
to asomsiko/openvino
that referenced
this pull request
Oct 13, 2020
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Dec 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix contains optimisations for MKLDNN nodes factory. Algorithm complexity for graph nodes creation reduced from O(N*N) to O(N). All changes are taken from PR 1741.