[GNA] clear input scale factor from configuration for imported model#2172
Merged
dorloff merged 3 commits intoopenvinotoolkit:masterfrom Sep 29, 2020
Merged
Conversation
2ba8076 to
33fd11c
Compare
Contributor
|
Needs to be rebased I think |
e41daee to
219abce
Compare
bsochack
approved these changes
Sep 25, 2020
219abce to
a2c853d
Compare
dorloff
reviewed
Sep 28, 2020
| } | ||
| } | ||
| } else { | ||
| slog::info << "Using scale factor from provided exported gna model: " << FLAGS_rg << slog::endl; |
Contributor
There was a problem hiding this comment.
I think we should warn the user if the scale factors were set through the command line when exporting a model, not only log it. We don't need to analyze them, just report something line this: "Using the scale factor from the exported (maybe imported??) model, the user-defined scale factors will be ignored".
If everything's fine, I am not sure it makes sense to report this at all.
a2c853d to
ceaecd0
Compare
ceaecd0 to
67cedbc
Compare
dorloff
approved these changes
Sep 29, 2020
asomsiko
pushed a commit
to asomsiko/openvino
that referenced
this pull request
Oct 13, 2020
…penvinotoolkit#2172) * [GNA] clear input scale factor from configuration for imported model * add test * [GNA] add warning for using imported scale factors
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Dec 16, 2020
…penvinotoolkit#2172) * [GNA] clear input scale factor from configuration for imported model * add test * [GNA] add warning for using imported scale factors
tadamowicz
pushed a commit
to tadamowicz/openvino
that referenced
this pull request
Aug 30, 2023
…penvinotoolkit#2172) * [GNA] clear input scale factor from configuration for imported model * add test * [GNA] add warning for using imported scale factors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: 35235