Refactored with single dispatch generic function implementation #19958
Refactored with single dispatch generic function implementation #19958ilya-lavrenov merged 7 commits intoopenvinotoolkit:masterfrom
Conversation
|
build_jenkins |
|
I am new to jenkins, is there any docs to build jenkins... |
Ilya's comment was in a fact command to run our Jenkins for you, so no, you don't have to do anything :) |
|
Gotcha! |
p-wysocki
left a comment
There was a problem hiding this comment.
LGTM, thank you for your contribution!
@jiwaszki do you know if we can merge this PR before #19534 is merged? Python 3.7 does not have built-in singledispatch, but I see that data_dispatcher.py also doesn't do any magic with importing it, so I suppose this PR will work with Python 3.7, right? Until we get an answer, I'm putting on a do_not_merge label.
@mahimairaja could you please take a look at Python API checks? It seems that mypy is failing. Please keep in mind that if fixing the mypy issue isn't practical, skipping the line is an option too.
|
Thank you @p-wysocki :) |
|
I am not sure, I added the return type and added the patches for linting only but the build has failed... |
|
@mahimairaja that seems like a sporadic Azure error, I restarted the pipeline. |
./src/openvino/preprocess/torchvision/torchvision_preprocessing.py:57:32: E261 at least two spaces before inline comment
return int(size), int(size) # type: ignore |
src/bindings/python/src/openvino/preprocess/torchvision/torchvision_preprocessing.py
Outdated
Show resolved
Hide resolved
…ision_preprocessing.py
src/bindings/python/src/openvino/preprocess/torchvision/torchvision_preprocessing.py
Outdated
Show resolved
Hide resolved
…ision_preprocessing.py
This comment was marked as outdated.
This comment was marked as outdated.
|
Is the PR is good to go? @p-wysocki |
we are waiting for last CI checks, but from code review perspective it looks like ready to merge :) |
|
There were some CI failures, but nothing on your side I think. I merged master, it helped on another PR with the same issue. Let's hope CI passes now. |
This comment was marked as outdated.
This comment was marked as outdated.
|
build_jenkins |
@p-wysocki yes, it will work. I am going to remove the label. |
|
Thank you team :) |
…vinotoolkit#19958) * Refactored with single dispatch generic function implementation * Resolved mypy linting warnings * Update src/bindings/python/src/openvino/preprocess/torchvision/torchvision_preprocessing.py * Update src/bindings/python/src/openvino/preprocess/torchvision/torchvision_preprocessing.py --------- Co-authored-by: Przemyslaw Wysocki <przemyslaw.wysocki@intel.com>
Details:
Added single dispatch generic function implementation
torchvision_preprocessing.py Line 50
torchvision_preprocessing.py Line 70
Tickets:
Refactor torchvision preprocessing converter into Python singledispatch
Closes #19912