Skip to content

Removed v0 convolution and group convolution#1512

Merged
ilyachur merged 1 commit intoopenvinotoolkit:masterfrom
ilyachur:feature/ichuraev/remove_conv_v0
Jul 31, 2020
Merged

Removed v0 convolution and group convolution#1512
ilyachur merged 1 commit intoopenvinotoolkit:masterfrom
ilyachur:feature/ichuraev/remove_conv_v0

Conversation

@ilyachur
Copy link
Copy Markdown
Contributor

@ilyachur ilyachur commented Jul 28, 2020

No description provided.

@ilyachur ilyachur requested a review from a team July 28, 2020 12:36
@ilyachur ilyachur force-pushed the feature/ichuraev/remove_conv_v0 branch from 7947512 to 7613fbb Compare July 28, 2020 12:39
@ilyachur ilyachur requested review from postrational and tomdol July 28, 2020 14:38
@ilyachur ilyachur force-pushed the feature/ichuraev/remove_conv_v0 branch 2 times, most recently from 3045fce to 546067c Compare July 30, 2020 09:26
@ilyachur ilyachur force-pushed the feature/ichuraev/remove_conv_v0 branch from 546067c to 43fb7f4 Compare July 30, 2020 09:38
@ilya-lavrenov ilya-lavrenov added the category: Core OpenVINO Core (aka ngraph) label Jul 30, 2020
@ilya-lavrenov ilya-lavrenov added this to the 2021.1 milestone Jul 30, 2020
@ilyachur ilyachur requested a review from tsocha July 30, 2020 13:27
tsocha
tsocha reviewed Jul 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tsocha tsocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we really need to move these v0 conv ops into test directory.
Can we just remove it?
If you want to keep it here please create a ticket to clean-up it in the future.

Its better to keep old code in the version control instead of adding garbage to the test folder IMHO.

@ilyachur
Copy link
Copy Markdown
Contributor Author

ilyachur commented Jul 30, 2020

I'm not sure if we really need to move these v0 conv ops into test directory.
Can we just remove it?
If you want to keep it here please create a ticket to clean-up it in the future.

Its better to keep old code in the version control instead of adding garbage to the test folder IMHO.

I moved v0 convolution to test folder because at the current moment it is used in the Interpreter plugin.
As I know @mikhail-treskin already make some experiments to migrate Interpreter from opset0 to opset1.

GlebKazantaev
GlebKazantaev reviewed Jul 31, 2020
View reviewed changes
GlebKazantaev
GlebKazantaev reviewed Jul 31, 2020
View reviewed changes
@ilyachur ilyachur merged commit 41da44e into openvinotoolkit:master Jul 31, 2020
@ilyachur ilyachur deleted the feature/ichuraev/remove_conv_v0 branch July 31, 2020 10:00
ilya-lavrenov pushed a commit to ilya-lavrenov/openvino that referenced this pull request Jul 31, 2020
@ilyachur @ilya-lavrenov
Removed v0 convolution and group convolution (openvinotoolkit#1512)
aa92f48
RomanZm pushed a commit to RomanZm/openvino that referenced this pull request Aug 28, 2020
@ilyachur
Removed v0 convolution and group convolution (openvinotoolkit#1512)
35d7889
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@postrational postrational Awaiting requested review from postrational

@tomdol tomdol Awaiting requested review from tomdol

3 more reviewers

@GlebKazantaev GlebKazantaev GlebKazantaev left review comments

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@tsocha tsocha tsocha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@postrational postrational

@GlebKazantaev GlebKazantaev

@tomdol tomdol

@tsocha tsocha

Labels

category: Core OpenVINO Core (aka ngraph)

Projects

None yet

Milestone

2021.1

Development

Successfully merging this pull request may close these issues.

6 participants

@ilyachur @ilya-lavrenov @GlebKazantaev @tsocha @postrational @tomdol