Skip to content

Add limits module#262

Merged
fmount merged 1 commit intoopenstack-k8s-operators:mainfrom
konan-abhi:unified-limits
Jun 1, 2023
Merged

Add limits module#262
fmount merged 1 commit intoopenstack-k8s-operators:mainfrom
konan-abhi:unified-limits

Conversation

@konan-abhi
Copy link
Copy Markdown
Contributor

@konan-abhi konan-abhi commented May 8, 2023 •
edited
Loading

E.g. used in keystone service to register limits for particular service.

This includes gophercloud version bump to 1.4.0

@konan-abhi konan-abhi requested a review from fmount May 8, 2023 14:38
@konan-abhi konan-abhi force-pushed the unified-limits branch 2 times, most recently from f8f9cc8 to db10b57 Compare May 8, 2023 15:09
fmount added a commit to fmount/glance-operator that referenced this pull request May 10, 2023
@fmount
Enforce Per-Tenant Quotas configuration
8c41ee8 
This patch exposes a boolean that can be used to enforce per-tenant
quotas in the GlanceAPI.
If true, the related glance-api section is enabled and templateParameters
are populated.
This patch assumes the quota resources are already registered in
keystone.

Depends-On: openstack-k8s-operators/lib-common/pull/262

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@fmount fmount mentioned this pull request May 10, 2023
Closed
fmount added a commit to fmount/glance-operator that referenced this pull request May 10, 2023
@fmount
Enforce Per-Tenant Quotas configuration
fd5f080 
This patch exposes a boolean that can be used to enforce per-tenant
quotas in the GlanceAPI.
If true, the related glance-api section is enabled and templateParameters
are populated.
This patch assumes the quota resources are already registered in
keystone.

Depends-On: openstack-k8s-operators/lib-common/pull/262
Depends-On: gophercloud/gophercloud/pull/2616

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@fmount fmount mentioned this pull request May 15, 2023
Merged
@konan-abhi konan-abhi changed the title DNM - Add limits module Add limits module May 16, 2023
@konan-abhi konan-abhi force-pushed the unified-limits branch 2 times, most recently from 740f94e to 14a3474 Compare May 23, 2023 06:25
@konan-abhi konan-abhi force-pushed the unified-limits branch 2 times, most recently from 535f160 to cbb6106 Compare May 25, 2023 09:57
@fmount
Copy link
Copy Markdown
Contributor

fmount commented May 25, 2023

+1 from me, let's merge as long as the CI is green (I suspect we should fix pre-commit tests)

@konan-abhi
Copy link
Copy Markdown
Contributor Author

konan-abhi commented May 25, 2023

+1 from me, let's merge as long as the CI is green (I suspect we should fix pre-commit tests)

Any inputs on how to fix those?

@fmount
Copy link
Copy Markdown
Contributor

fmount commented May 25, 2023

+1 from me, let's merge as long as the CI is green (I suspect we should fix pre-commit tests)

Any inputs on how to fix those?

on your local branch, run pre-commit run --all-files and git add the resulting changes.
With that it should work on the next iteration!

@konan-abhi
Copy link
Copy Markdown
Contributor Author

konan-abhi commented May 26, 2023

pre-commit run --all-files

Thank you!

fmount
fmount approved these changes May 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

fmount
fmount reviewed May 26, 2023
View reviewed changes
modules/openstack/go.mod
require (
github.com/go-logr/logr v1.2.4
github.com/gophercloud/gophercloud v1.2.0
github.com/gophercloud/gophercloud v1.4.0
Copy link
Copy Markdown
Contributor

@fmount fmount May 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuggi || @abays FYI bumping gophercloud to 1.4.0 to get [1] in. Any issues with that ?

[1] gophercloud/gophercloud#2616

Copy link
Copy Markdown
Contributor

@abays abays Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it's fine if everything still works :)

@fmount fmount requested a review from stuggi May 26, 2023 11:49
@konan-abhi
Add limits module
6c9001f 
E.g. used in keystone service to register limits for particular
service.

This includes gophercloud version bump to 1.4.0
@fmount fmount requested a review from abays June 1, 2023 08:37
@fmount fmount merged commit 30a4a76 into openstack-k8s-operators:main Jun 1, 2023
fmount added a commit to fmount/glance-operator that referenced this pull request Jun 6, 2023
@fmount
Enforce Per-Tenant Quotas configuration
3dc2378 
This patch exposes a boolean that can be used to enforce per-tenant
quotas in the GlanceAPI.
If true, the related glance-api section is enabled and templateParameters
are populated.
This patch assumes the quota resources are already registered in
keystone.

Depends-On: openstack-k8s-operators/lib-common/pull/262
Depends-On: gophercloud/gophercloud/pull/2616

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
fmount added a commit to fmount/glance-operator that referenced this pull request Jun 6, 2023
@fmount
Enforce Per-Tenant Quotas configuration
ca6f987 
This patch exposes a boolean that can be used to enforce per-tenant
quotas in the GlanceAPI.
If true, the related glance-api section is enabled and templateParameters
are populated.
This patch assumes the quota resources are already registered in
keystone.

Depends-On: openstack-k8s-operators/lib-common/pull/262
Depends-On: gophercloud/gophercloud/pull/2616

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
fmount added a commit to fmount/glance-operator that referenced this pull request Jun 10, 2023
@fmount
Enforce Per-Tenant Quotas configuration
3101679 
This patch exposes a boolean that can be used to enforce per-tenant
quotas in the GlanceAPI.
If true, the related glance-api section is enabled and templateParameters
are populated.
This patch assumes the quota resources are already registered in
keystone.

Depends-On: openstack-k8s-operators/lib-common/pull/262
Depends-On: gophercloud/gophercloud/pull/2616

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
fmount added a commit to fmount/glance-operator that referenced this pull request Jun 10, 2023
@fmount
Enforce Per-Tenant Quotas configuration
d37d117 
This patch exposes a boolean that can be used to enforce per-tenant
quotas in the GlanceAPI.
If true, the related glance-api section is enabled and templateParameters
are populated.
This patch assumes the quota resources are already registered in
keystone.

Depends-On: openstack-k8s-operators/lib-common/pull/262
Depends-On: gophercloud/gophercloud/pull/2616

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
fmount added a commit to fmount/glance-operator that referenced this pull request Jun 10, 2023
@fmount
Enforce Per-Tenant Quotas configuration
ca6cc0a 
This patch exposes a boolean that can be used to enforce per-tenant
quotas in the GlanceAPI.
If true, the related glance-api section is enabled and templateParameters
are populated.
This patch assumes the quota resources are already registered in
keystone.

Depends-On: openstack-k8s-operators/lib-common/pull/262
Depends-On: gophercloud/gophercloud/pull/2616

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
fmount added a commit to fmount/glance-operator that referenced this pull request Jun 10, 2023
@fmount
Enforce Per-Tenant Quotas configuration
f8ba8a3 
This patch exposes a boolean that can be used to enforce per-tenant
quotas in the GlanceAPI.
If true, the related glance-api section is enabled and templateParameters
are populated.
This patch assumes the quota resources are already registered in
keystone.

Depends-On: openstack-k8s-operators/lib-common/pull/262
Depends-On: gophercloud/gophercloud/pull/2616
Depends-On: openstack-k8s-operators/lib-common/pull/284

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
fmount added a commit to fmount/glance-operator that referenced this pull request Jun 10, 2023
@fmount
Enforce Per-Tenant Quotas configuration
f3a1b21 
This patch exposes the data structure and implement the related logic
that can be used to enforce per-tenant quotas in the GlanceAPI. When
limits are defined, the related glance-api config section is enabled and
templateParameters are populated.

Depends-On: openstack-k8s-operators/lib-common/pull/262
Depends-On: gophercloud/gophercloud/pull/2616
Depends-On: openstack-k8s-operators/lib-common/pull/284

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
fmount added a commit to fmount/glance-operator that referenced this pull request Jun 12, 2023
@fmount
Enforce Per-Tenant Quotas configuration
5c1ae9b 
This patch exposes the data structure and implement the related logic
that can be used to enforce per-tenant quotas in the GlanceAPI. When
limits are defined, the related glance-api config section is enabled and
templateParameters are populated.

Depends-On: openstack-k8s-operators/lib-common/pull/262
Depends-On: gophercloud/gophercloud/pull/2616
Depends-On: openstack-k8s-operators/lib-common/pull/284

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
fmount added a commit to fmount/glance-operator that referenced this pull request Jun 12, 2023
@fmount
Enforce Per-Tenant Quotas configuration
97f9012 
This patch exposes the data structure and implement the related logic
that can be used to enforce per-tenant quotas in the GlanceAPI. When
limits are defined, the related glance-api config section is enabled and
templateParameters are populated.

Depends-On: openstack-k8s-operators/lib-common/pull/262
Depends-On: gophercloud/gophercloud/pull/2616
Depends-On: openstack-k8s-operators/lib-common/pull/284

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
fmount added a commit to fmount/glance-operator that referenced this pull request Jun 12, 2023
@fmount
Enforce Per-Tenant Quotas configuration
5aae648 
This patch exposes the data structure and implement the related logic
that can be used to enforce per-tenant quotas in the GlanceAPI. When
limits are defined, the related glance-api config section is enabled and
templateParameters are populated.

Depends-On: openstack-k8s-operators/lib-common/pull/262
Depends-On: gophercloud/gophercloud/pull/2616
Depends-On: openstack-k8s-operators/lib-common/pull/284

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
fmount added a commit to fmount/glance-operator that referenced this pull request Jun 12, 2023
@fmount
Enforce Per-Tenant Quotas configuration
460f094 
This patch exposes the data structure and implement the related logic
that can be used to enforce per-tenant quotas in the GlanceAPI. When
limits are defined, the related glance-api config section is enabled and
templateParameters are populated.

Depends-On: openstack-k8s-operators/lib-common/pull/262
Depends-On: gophercloud/gophercloud/pull/2616
Depends-On: openstack-k8s-operators/lib-common/pull/284

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmount fmount fmount approved these changes

@stuggi stuggi Awaiting requested review from stuggi

@abays abays Awaiting requested review from abays

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@konan-abhi @fmount @abays