Closed
Conversation
Member
Author
|
When merged with #8985, I get this display: |
Member
Author
|
|
2 tasks
c233f28 to
7f09739
Compare
Member
Author
|
Not WIP any more |
Member
|
CI failures are relevant unfortunately. |
bdc3476 to
8681819
Compare
mattcaswell
requested changes
Oct 14, 2019
d3db6ac to
edd56bc
Compare
Member
|
Needs a rebase |
Member
Author
|
Done |
edd56bc to
768922c
Compare
Member
|
doc-nits is complaining |
Member
Author
|
doc-nits failure fixed |
t8m
reviewed
Oct 16, 2019
ffd9eda to
5044bad
Compare
Member
Author
|
CIs are good, libcrypto.num needs an adjustment. Does your approval hold for that? |
Clean up a few manual pages that we're about to touch, according to conventions found in Linux' man-pages(7); function arguments in descriptions should be in italics, and types, macros and similar should be in bold, with the exception for NULL.
63565b5 to
b2f9886
Compare
This adds the missing functions that should be common for all fetchable EVP sub-APIs: EVP_KEYMGMT_is_a(), EVP_KEYMGMT_do_all_provided(), EVP_KEYEXCH_is_a(), EVP_KEYEXCH_do_all_provided(), EVP_KDF_is_a(), EVP_MD_is_a(), EVP_SIGNATURE_do_all_provided(), EVP_SIGNATURE_is_a(). This also renames EVP_MD_do_all_ex(), EVP_CIPHER_do_all_ex(), EVP_KDF_do_all_ex(), EVP_MAC_do_all_ex() to change '_ex' to '_provided'.
Member
|
Yes |
The following new functions all do the same thing; they traverse the set of names assigned to implementations of each algorithm type: EVP_MD_names_do_all(), EVP_CIPHER_names_do_all(), EVP_MAC_names_do_all(), EVP_KEYMGMT_names_do_all(), EVP_KEYEXCH_names_do_all(), EVP_KDF_names_do_all(), EVP_SIGNATURE_names_do_all() We add a warning to the documentation of EVP_CIPHER_name() and EVP_MD_name(), as they aren't suitable to use with multiple-name implementation. We also remove EVP_MAC_name() and evp_KDF_name(), as they serve no useful purpose.
The returned number can be used for comparison purposes.
Method data was passed down as provider to ossl_algorithm_do_all(), which causes trouble as soon a it's non-NULL. Pass it via the data structure instead.
"name_cmp" caused a clash when linking with the static libcrypto. The slight rename is better than nothing, as v3_ is an already existing prefix.
b2f9886 to
4dae7a2
Compare
Member
Author
|
Argh, the squash was more laborious than I thought it was going to be. Please re-review |
t8m
approved these changes
Oct 16, 2019
levitte
added a commit
that referenced
this pull request
Oct 17, 2019
Clean up a few manual pages that we're about to touch, according to conventions found in Linux' man-pages(7); function arguments in descriptions should be in italics, and types, macros and similar should be in bold, with the exception for NULL. Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #9979)
levitte
added a commit
that referenced
this pull request
Oct 17, 2019
This adds the missing functions that should be common for all fetchable EVP sub-APIs: EVP_KEYMGMT_is_a(), EVP_KEYMGMT_do_all_provided(), EVP_KEYEXCH_is_a(), EVP_KEYEXCH_do_all_provided(), EVP_KDF_is_a(), EVP_MD_is_a(), EVP_SIGNATURE_do_all_provided(), EVP_SIGNATURE_is_a(). This also renames EVP_MD_do_all_ex(), EVP_CIPHER_do_all_ex(), EVP_KDF_do_all_ex(), EVP_MAC_do_all_ex() to change '_ex' to '_provided'. Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #9979)
levitte
added a commit
that referenced
this pull request
Oct 17, 2019
The following new functions all do the same thing; they traverse the set of names assigned to implementations of each algorithm type: EVP_MD_names_do_all(), EVP_CIPHER_names_do_all(), EVP_MAC_names_do_all(), EVP_KEYMGMT_names_do_all(), EVP_KEYEXCH_names_do_all(), EVP_KDF_names_do_all(), EVP_SIGNATURE_names_do_all() We add a warning to the documentation of EVP_CIPHER_name() and EVP_MD_name(), as they aren't suitable to use with multiple-name implementation. We also remove EVP_MAC_name() and evp_KDF_name(), as they serve no useful purpose. Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #9979)
levitte
added a commit
that referenced
this pull request
Oct 17, 2019
The returned number can be used for comparison purposes. Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #9979)
levitte
added a commit
that referenced
this pull request
Oct 17, 2019
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #9979)
levitte
added a commit
that referenced
this pull request
Oct 17, 2019
Method data was passed down as provider to ossl_algorithm_do_all(), which causes trouble as soon a it's non-NULL. Pass it via the data structure instead. Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #9979)
levitte
added a commit
that referenced
this pull request
Oct 17, 2019
"name_cmp" caused a clash when linking with the static libcrypto. The slight rename is better than nothing, as v3_ is an already existing prefix. Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #9979)
Member
Author
|
Thank you all! Merged. ee2161e Some docs cleanup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the functionality necessary to display multiple names on provided algorithm implementations nicely. While I was at it, I also added missing common functions related to fetched implementations.