Fix up some undocumented commands issues #9974
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
levitte
requested changes
Sep 23, 2019
Contributor
Author
|
I think I want to add all the missing "for comment ifdef"'s today. I can do it as part of this PR. |
Contributor
Author
|
Rebased, added all commands #ifdef options, and squashed. This can be merged. |
Contributor
Author
|
Removed renaming the two POD files since that is now handled, more completely, in PR #10000 |
t8m
approved these changes
Sep 26, 2019
Member
|
Ping for second review. My approval still holds. |
Make find-doc-nits understand that
=for comment ifdef ssl3 ...
in a POD page means that the "-ssl3" flag might be ifdef'd out in the
local environment, and not to complain about it.
Member
|
And still holds. |
levitte
approved these changes
Sep 30, 2019
Contributor
Author
|
This is ready to merge; the "pending 2nd review" label is outdated. |
levitte
pushed a commit
that referenced
this pull request
Oct 1, 2019
Make find-doc-nits understand that
=for comment ifdef ssl3 ...
in a POD page means that the "-ssl3" flag might be ifdef'd out in the
local environment, and not to complain about it.
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #9974)
Member
|
Merged. 1738c0c Add '=for comment ifdef' to pod pages |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make find-doc-nits understand that
=for comment ifdef ssl3
in a POD page means that the "-ssl3" command might be ifdef'd out in the
local environment, and not to complain about it.
Added a handful of those lines to pages that complain for me.
Additional flags will probably have to be added.