Avoid overflowing FDSET when using select(2). #9686
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a problem in the rand_unix.c code when the random seed fd is greater than or equal to FD_SETSIZE and the FDSET overruns its limit and walks the stack.
bernd-edlinger
approved these changes
Aug 24, 2019
levitte
pushed a commit
that referenced
this pull request
Aug 24, 2019
There is a problem in the rand_unix.c code when the random seed fd is greater than or equal to FD_SETSIZE and the FDSET overruns its limit and walks the stack. Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from #9686)
Contributor
Author
|
Merged to master and 1.1.1. Thanks. |
arcadia-devtools
pushed a commit
to catboost/catboost
that referenced
this pull request
Aug 29, 2019
It was deleted in openssl/openssl#9084 It corrupts the stack: openssl/openssl#9686 Note: mandatory check (NEED_CHECK) was skipped ref:23dc8df65263efcb9cc1e95187a6597a15c60e49
vdukhovni
reviewed
Aug 29, 2019
| /* Open /dev/random and wait for it to be readable */ | ||
| if ((fd = open(DEVRANDOM_WAIT, O_RDONLY)) != -1) { | ||
| if (DEVRANDM_WAIT_USE_SELECT) { | ||
| if (DEVRANDM_WAIT_USE_SELECT && fd < FD_SETSIZE) { |
There was a problem hiding this comment.
Why not just switch to use poll(2)? Do we really support Linux versions that lack poll()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem in the rand_unix.c code when the random seed fd is greater
than or equal to FD_SETSIZE and the FDSET overruns its limit and walks the
stack.