Provide an ability to deregister thread stop handlers#9186
Closed
mattcaswell wants to merge 3 commits intoopenssl:masterfrom
Closed
Provide an ability to deregister thread stop handlers#9186mattcaswell wants to merge 3 commits intoopenssl:masterfrom
mattcaswell wants to merge 3 commits intoopenssl:masterfrom
Conversation
If a provider gets unloaded then any thread stop handlers that it had registered will be left hanging. We should clean them up before tearing down the provider.
levitte
requested changes
Jun 18, 2019
levitte
reviewed
Jun 18, 2019
Member
|
Relevant Travis failure: |
Member
Author
|
New commits pushed addressing feedback so far and (hopefully) fixing the travis failure. |
Member
|
New relevant Travis failure: |
levitte
approved these changes
Jun 19, 2019
Member
levitte
left a comment
There was a problem hiding this comment.
With the assumption that the documentation nit indicated by the Travis failure gets corrected...
Member
|
Thanks for the documentation, it brought much needed clarity and made it easier to review. |
Member
Author
|
doc-nits issue fixed. Pushed to master. Thanks! |
levitte
pushed a commit
that referenced
this pull request
Jun 19, 2019
If a provider gets unloaded then any thread stop handlers that it had registered will be left hanging. We should clean them up before tearing down the provider. Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #9186)
levitte
pushed a commit
that referenced
this pull request
Jun 19, 2019
Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #9186)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a provider gets unloaded then any thread stop handlers that it had
registered will be left hanging. We should clean them up before tearing
down the provider.
This is necessary before #9035 can be merged.