Revert the DEVRANDOM_WAIT feature [1.1.1] #9118
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DEVRANDOM_WAIT feature added a select() call to wait for the `/dev/random` device to become readable before reading from the `/dev/urandom` device. It was introduced in commit 38023b8 in order to mitigate the fact that the `/dev/urandom` device does not block until the initial seeding of the kernel CSPRNG has completed, contrary to the behaviour of the `getrandom()` system call. It turned out that this change had negative side effects on the performance which were not acceptable. After some discussion it was decided to revert this feature and leave it up to the OS resp. the platform maintainer to ensure a proper initialization during early boot time. Fixes openssl#9078 This partially reverts commit 38023b8. (cherry picked from commit c19c5a6)
2 tasks
32fffba to
55df89e
Compare
t-j-h
reviewed
Jun 9, 2019
| On older Linux systems where the getrandom() system call is not available, | ||
| OpenSSL normally uses the /dev/urandom device for seeding its CSPRNG. | ||
| Contrary to getrandom(), the /dev/urandom device will not block during | ||
| early boot when the kernel CSPRNG has not been initially seeded yet. |
Member
There was a problem hiding this comment.
"initially seeded yet" is a tautology - either "initially seeded" or "seeded yet".
Contributor
Author
There was a problem hiding this comment.
I'll go for "has not been seeded yet."
t-j-h
approved these changes
Jun 9, 2019
Member
t-j-h
left a comment
There was a problem hiding this comment.
The wording should be adjusted - but I'll leave that to you.
vdukhovni
approved these changes
Jun 9, 2019
vdukhovni
left a comment
There was a problem hiding this comment.
Approved, with minor nits on the phrasing of the change log.
| /dev/random device to become readable before reading from the | ||
| /dev/urandom device. | ||
|
|
||
| It turned out that this change had negative side effects on the |
There was a problem hiding this comment.
A bit clumsy, but just removing the word "the" will be close enough.
Contributor
Author
There was a problem hiding this comment.
Ok. I'll remove the "the" here and in the commit message.
levitte
pushed a commit
that referenced
this pull request
Jun 9, 2019
The DEVRANDOM_WAIT feature added a select() call to wait for the `/dev/random` device to become readable before reading from the `/dev/urandom` device. It was introduced in commit 38023b8 in order to mitigate the fact that the `/dev/urandom` device does not block until the initial seeding of the kernel CSPRNG has completed, contrary to the behaviour of the `getrandom()` system call. It turned out that this change had negative side effects on performance which were not acceptable. After some discussion it was decided to revert this feature and leave it up to the OS resp. the platform maintainer to ensure a proper initialization during early boot time. Fixes #9078 This partially reverts commit 38023b8. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Viktor Dukhovni <viktor@openssl.org> (cherry picked from commit a08714e) (Merged from #9118)
levitte
pushed a commit
that referenced
this pull request
Jun 9, 2019
Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Viktor Dukhovni <viktor@openssl.org> (Merged from #9118)
Contributor
Author
themiron
pushed a commit
to RMerl/asuswrt-merlin.ng
that referenced
this pull request
Jun 12, 2019
The DEVRANDOM_WAIT feature added a select() call to wait for the `/dev/random` device to become readable before reading from the `/dev/urandom` device. It was introduced in commit 38023b87f037 in order to mitigate the fact that the `/dev/urandom` device does not block until the initial seeding of the kernel CSPRNG has completed, contrary to the behaviour of the `getrandom()` system call. It turned out that this change had negative side effects on performance which were not acceptable. After some discussion it was decided to revert this feature and leave it up to the OS resp. the platform maintainer to ensure a proper initialization during early boot time. Fixes #9078 This partially reverts commit 38023b87f037. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Viktor Dukhovni <viktor@openssl.org> (cherry picked from commit a08714e18131b1998faa0113e5bd4024044654ac) (Merged from openssl/openssl#9118)
john9527
pushed a commit
to john9527/asuswrt-merlin
that referenced
this pull request
Feb 13, 2020
The DEVRANDOM_WAIT feature added a select() call to wait for the `/dev/random` device to become readable before reading from the `/dev/urandom` device. It was introduced in commit 38023b87f037 in order to mitigate the fact that the `/dev/urandom` device does not block until the initial seeding of the kernel CSPRNG has completed, contrary to the behaviour of the `getrandom()` system call. It turned out that this change had negative side effects on performance which were not acceptable. After some discussion it was decided to revert this feature and leave it up to the OS resp. the platform maintainer to ensure a proper initialization during early boot time. Fixes #9078 This partially reverts commit 38023b87f037. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Viktor Dukhovni <viktor@openssl.org> (cherry picked from commit a08714e18131b1998faa0113e5bd4024044654ac) (Merged from openssl/openssl#9118)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit of this pull request is the (unmodified) cherry-pick of #9084, the second adds the CHANGES entries:
82c4bcb Revert the DEVRANDOM_WAIT feature (cherry picked from commit c19c5a6)
55df89e Add CHANGES entries for the DEVRANDOM_WAIT feature and its removal.