Skip to content

Fixed typo in code comment.#9102

Closed
davidmakepeace wants to merge 1 commit intoopenssl:masterfrom
davidmakepeace:fix-comment-typo
Closed

Fixed typo in code comment.#9102
davidmakepeace wants to merge 1 commit intoopenssl:masterfrom
davidmakepeace:fix-comment-typo

Conversation

@davidmakepeace
Copy link
Contributor

@davidmakepeace davidmakepeace commented Jun 7, 2019

The comment is for a block of EC Public Key test data (negative test).
[skip ci]

Checklist
  • documentation is added or updated
  • tests are added or updated

@levitte
Copy link
Member

levitte commented Jun 7, 2019

Is this master only, or should it go to 1.1.1 as well?

@levitte levitte added the approval: review pending This pull request needs review by a committer label Jun 7, 2019
@t-j-h t-j-h added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jun 7, 2019
@mspncp
Copy link
Contributor

mspncp commented Jun 7, 2019 •
edited
Loading

Yes, the typo is also in 1.1.1:

openssl/test/evp_extra_test.c

Lines 302 to 306 in 7818cd3

/*
* kExampleBadECKeyDER is a sample EC public key with a wrong OID
* 1.2.840.10045.2.2 instead of 1.2.840.10045.2.1 - EC Public Key
*/
static const unsigned char kExampleBadECPubKeyDER[] = {

@mspncp mspncp added branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) branch: master Applies to master branch labels Jun 7, 2019
mspncp
mspncp approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@mspncp mspncp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for master and 1.1.1

levitte pushed a commit that referenced this pull request Jun 7, 2019
@davidmakepeace @levitte
Fixed typo in code comment.
38a277e 
[skip ci]

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #9102)

(cherry picked from commit 8776293)
@levitte
Copy link
Member

levitte commented Jun 7, 2019

Merged.

master:
8776293 Fixed typo in code comment. [skip ci]

1.1.1:
38a277e Fixed typo in code comment. [skip ci]

@levitte levitte closed this Jun 7, 2019
paulidale
paulidale approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for both too.

@davidmakepeace davidmakepeace deleted the fix-comment-typo branch June 8, 2019 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@levitte levitte levitte approved these changes

@t-j-h t-j-h t-j-h approved these changes

@paulidale paulidale paulidale approved these changes

+1 more reviewer

@mspncp mspncp mspncp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approval: done This pull request has the required number of approvals branch: master Applies to master branch branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@davidmakepeace @levitte @mspncp @t-j-h @paulidale