Skip to content

rename the digest provider files to avoid any name clashes with other…#9083

Closed
slontis wants to merge 1 commit intoopenssl:masterfrom
slontis:dup_prov_names
Closed

rename the digest provider files to avoid any name clashes with other…#9083
slontis wants to merge 1 commit intoopenssl:masterfrom
slontis:dup_prov_names

Conversation

@slontis
Copy link
Member

@slontis slontis commented Jun 5, 2019

… folders

Checklist
  • documentation is added or updated
  • tests are added or updated

@slontis
Copy link
Member Author

slontis commented Jun 5, 2019

@jon-oracle

levitte
levitte reviewed Jun 5, 2019
View reviewed changes
providers/default/digests/build.info
@@ -1,17 +1,17 @@
SOURCE[../../../libcrypto]=\
null.c
null_prov.c
Copy link
Member

@levitte levitte Jun 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right, I noticed that one yesterday... why does it exist at all?

Note that this isn't meant to impact this PR, but is rather a heads up for another cleanup PR

Copy link
Member Author

@slontis slontis Jun 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is equivalent to EVP_MD null_md. I dont know if it is needed or not.

@levitte
Copy link
Member

levitte commented Jun 5, 2019

I'd like to know what it was that gave this away? I might encounter similar issues with #8877, so if there's some automated way we can use to detect this sort of mistake, that would be great.

mattcaswell
mattcaswell approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis failure is unrelated and is instead due to #9042 (comment)

@slontis
Copy link
Member Author

slontis commented Jun 5, 2019 •
edited
Loading

here's some automated way we can use to detect this sort of mistake, that would be great.

We were using
ar -x to extract all the .o files into a folder.
Joining them back into a shared object then has missing symbols.
Maybe the -N option will give you something..

@jon-oracle
Copy link
Contributor

jon-oracle commented Jun 5, 2019 •
edited
Loading

Here's a script I created to check for duplicate object names in the static library:

ARCHIVE=<path-to-.a-file>

ar -t $ARCHIVE | grep "\.o" | sort > ar_objs

rm -rf tmp_ar
mkdir tmp_ar
cd tmp_ar
  ar x ../$ARCHIVE
  ls -1 | sort > ../ar_dir
cd ../

diff ar_objs ar_dir

levitte pushed a commit that referenced this pull request Jun 6, 2019
@slontis
rename the digest provider files to avoid any name clashes with other…
56e840f 
… folders

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #9083)
@slontis slontis closed this Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@levitte levitte levitte approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@slontis @levitte @jon-oracle @mattcaswell