Skip to content

Typo BIO_SOCK_REUSADDR => BIO_SOCK_REUSEADDR#9021

Closed
riuri wants to merge 1 commit intoopenssl:masterfrom
riuri:master
Closed

Typo BIO_SOCK_REUSADDR => BIO_SOCK_REUSEADDR#9021
riuri wants to merge 1 commit intoopenssl:masterfrom
riuri:master

Conversation

@riuri
Copy link
Contributor

@riuri riuri commented May 28, 2019 •
edited
Loading

CLA: trivial

Checklist
  • documentation is added or updated

@InfoHunter
Copy link
Member

InfoHunter commented May 28, 2019

Typo is worth a fix to stable branch, right?

@InfoHunter InfoHunter added branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) branch: master Applies to master branch approval: done This pull request has the required number of approvals labels May 28, 2019
@mspncp
Copy link
Contributor

mspncp commented May 28, 2019

Typo is worth a fix to stable branch, right?

I would say so.

@paulidale @InfoHunter please add your consent for the records that this is a trivial change.

@InfoHunter
Copy link
Member

InfoHunter commented May 28, 2019

please add your consent for the records that this is a trivial change.

Sure. I agree that this is trivial.

mattcaswell
mattcaswell approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is trivial

@paulidale
Copy link
Contributor

paulidale commented May 28, 2019

Yes, it trivial.

@paulidale
Copy link
Contributor

paulidale commented May 29, 2019

Merged to master and 1.1.1. Thanks for the fix.

@paulidale paulidale closed this May 29, 2019
levitte pushed a commit that referenced this pull request May 29, 2019
@riuri @paulidale
Typo BIO_SOCK_REUSADDR => BIO_SOCK_REUSEADDR
ea8d07b 
CLA: trivial

Reviewed-by: Paul Yang <yang.yang@baishancloud.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from #9021)
levitte pushed a commit that referenced this pull request May 29, 2019
@riuri @paulidale
Typo BIO_SOCK_REUSADDR => BIO_SOCK_REUSEADDR
2671490 
CLA: trivial

Reviewed-by: Paul Yang <yang.yang@baishancloud.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from #9021)

(cherry picked from commit ea8d07b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@InfoHunter InfoHunter InfoHunter approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees

No one assigned

Labels

approval: done This pull request has the required number of approvals branch: master Applies to master branch branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@riuri @InfoHunter @mspncp @paulidale @mattcaswell