Test of uniformity of BN_rand_range output.#8830
Closed
paulidale wants to merge 3 commits intoopenssl:masterfrom
Closed
Test of uniformity of BN_rand_range output.#8830paulidale wants to merge 3 commits intoopenssl:masterfrom
paulidale wants to merge 3 commits intoopenssl:masterfrom
Conversation
Contributor
Author
|
Thoughts @kroeckx ? |
Closed
kroeckx
reviewed
Apr 26, 2019
kroeckx
reviewed
Apr 26, 2019
Member
|
I think such tests can be useful, but since they can fail when ran enough time, and it will be ran enough times, we should not run them by default. |
Contributor
Author
|
Okay, a command line option to the test program to turn them on seems prudent. |
Contributor
Author
|
The |
Contributor
Author
|
Review @openssl/committers ? |
Contributor
Author
|
Could someone please review this? Thanks. |
mattcaswell
requested changes
May 7, 2019
richsalz
reviewed
May 7, 2019
Rework the test so that it fails far less often. A number of independent tests are executed and 5% are expected to fail. The number of such failures follows a binomial distribution which permits a statistical test a 0.01% expected failure rate. There is a command line option to enable the stochastic range checking. It is off by default.
Contributor
Author
|
AppVeyor failure isn't relevant. |
mattcaswell
requested changes
May 9, 2019
Contributor
Author
|
Ping @mattcaswell |
Contributor
Author
|
Ping @openssl/committers |
Contributor
Author
|
Still waiting review/confirmation. |
mattcaswell
approved these changes
May 28, 2019
Contributor
Author
|
Merged, thanks. |
levitte
pushed a commit
that referenced
this pull request
May 28, 2019
Rework the test so that it fails far less often. A number of independent tests are executed and 5% are expected to fail. The number of such failures follows a binomial distribution which permits a statistical test a 0.01% expected failure rate. There is a command line option to enable the stochastic range checking. It is off by default. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #8830)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the test so that it fails far less often.
A number of independent tests are executed and 5% are expected to fail.
The number of such failures follows a binomial distribution which permits
a statistical test a 0.01% expected failure rate.
An alternative fix to #8826