Rework DSO API conditions and configuration option#8622
Closed
levitte wants to merge 5 commits intoopenssl:masterfrom
Closed
Rework DSO API conditions and configuration option#8622levitte wants to merge 5 commits intoopenssl:masterfrom
levitte wants to merge 5 commits intoopenssl:masterfrom
Conversation
'no-dso' is meaningless, as it doesn't get any macro defined. Therefore, we remove all checks of OPENSSL_NO_DSO. However, there may be some odd platforms with no DSO scheme. For those, we generate the internal macro DSO_NONE aand use it.
richsalz
reviewed
Mar 31, 2019
Contributor
richsalz
left a comment
There was a problem hiding this comment.
Wow, kind of surprising how much simpler things got!
paulidale
approved these changes
Mar 31, 2019
Member
Author
|
A question: should this be back-ported to 1.1.1? The |
Member
Author
|
Meanwhile, I've merged into master. 31b6ed7 Rework DSO API conditions and configuration option |
Contributor
|
I think 1.1.1 too but don't feel strongly about it. |
Member
Author
|
Done in #8628 |
levitte
added a commit
that referenced
this pull request
Apr 10, 2019
'no-dso' is meaningless, as it doesn't get any macro defined. Therefore, we remove all checks of OPENSSL_NO_DSO. However, there may be some odd platforms with no DSO scheme. For those, we generate the internal macro DSO_NONE aand use it. Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #8622)
|
Hi, I guess, that with the removal of no-dso support, the no-dso build on Win is no longer supported? |
Member
Author
|
That's intended. That macro is really quite internal to the DSO sub-system, so it shouldn't make a difference outside of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'no-dso' is meaningless, as it doesn't get any macro defined.
Therefore, we remove all checks of OPENSSL_NO_DSO. However, there may
be some odd platforms with no DSO scheme. For those, we generate the
internal macro DSO_NONE and use it.