Fix broken change from b3d113e. #8606
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-j-h
approved these changes
Mar 28, 2019
Contributor
Author
|
I'm feeling guilty about making the breaking change... |
Contributor
Author
|
Merged, thanks @t-j-h |
2 tasks
levitte
pushed a commit
that referenced
this pull request
Mar 29, 2019
Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from #8606)
Member
|
This was not cherry-picked to 1.1.1. I am going to do it. |
levitte
pushed a commit
that referenced
this pull request
May 30, 2019
mrdeep1
added a commit
to mrdeep1/libcoap
that referenced
this pull request
Jun 25, 2019
Issue introduced by OpenSSL 1.1.1c causes valgrind errors to be reported. See https://www.mail-archive.com/openssl-commits@openssl.org/msg21701.html and openssl/openssl#8606 which did not make 1.1.1c scripts/build.sh: tests/valgrind_suppression: Temporarily suppress valgrind errors when SSL_CTS_New() is called when running the tests. Note: This suppression will also need to be applied when running valgrind against other CoAP executables using OpenSSL 1.1.1c to prevent the valgrind errors getting reported.
mrdeep1
added a commit
to mrdeep1/libcoap
that referenced
this pull request
Jun 25, 2019
Issue introduced by OpenSSL 1.1.1c causes valgrind errors to be reported. See https://www.mail-archive.com/openssl-commits@openssl.org/msg21701.html and openssl/openssl#8606 which did not make 1.1.1c scripts/build.sh: tests/valgrind_suppression: Temporarily suppress valgrind errors when SSL_CTS_new() is called when running the tests. Note: This suppression will also need to be applied when running valgrind against other CoAP executables using OpenSSL 1.1.1c to prevent the valgrind errors getting reported.
mrdeep1
added a commit
to mrdeep1/libcoap
that referenced
this pull request
Jun 25, 2019
Issue introduced by OpenSSL 1.1.1c causes valgrind errors to be reported. See https://www.mail-archive.com/openssl-commits@openssl.org/msg21701.html and openssl/openssl#8606 which did not make 1.1.1c scripts/build.sh: tests/valgrind_suppression: Temporarily suppress valgrind errors when SSL_CTS_new() is called when running the tests. Note: This suppression will also need to be applied when running valgrind against other CoAP executables using OpenSSL 1.1.1c to prevent the valgrind errors getting reported. src/coap_openssl.c: memset cookie_secret to 0 to stop valgrind warning.
mrdeep1
added a commit
to mrdeep1/libcoap
that referenced
this pull request
Jun 25, 2019
Issue introduced by OpenSSL 1.1.1c causes valgrind errors to be reported. See https://www.mail-archive.com/openssl-commits@openssl.org/msg21701.html and openssl/openssl#8606 which did not make 1.1.1c scripts/build.sh: tests/valgrind_suppression: Temporarily suppress valgrind errors when SSL_CTS_new() is called when running the tests. Note: This suppression will also need to be applied when running valgrind against other CoAP executables using OpenSSL 1.1.1c to prevent the valgrind errors getting reported. src/coap_openssl.c: memset cookie_secret to 0 to stop valgrind warning.
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #8603
Fixing the problem introduced in b3d113e using memset(3).
The underlying issue is that, on my machine, the size of data is 16 bytes, but the sizes of it's two feilds are 8 and 4 respectively. This leaves 4 bytes of padding. I don't think C guarantees to initialise this to zero in either of the assignment cases.
All of the data structure is added to the entropy pool (counting as zero entropy).