RT4310(again): Elide EVP_read_pw_string() and friends for no-ui build #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 This is a bugfix for 1.0.2, that failed to remove a function during no-ui config. |
Contributor
Author
|
Note this submission is to HEAD. I have a lot of backports to 1.0.2 and I'm not sure you want them all... |
Contributor
|
Okay, I was confused. You just need this separate so you can cherry-pick? |
Contributor
Author
|
Basically, yes. I need it committed so I can cherry-pick it. If you look at my 1.0.2 tree at http://git.infradead.org/users/dwmw2/openssl.git/shortlog/refs/heads/OpenSSL_1_0_2-stable you'll see everything I have there is backports from HEAD. This is the patch I'm planning to put into UEFI to replace their existing set of hacks. This patch I'm submitting to HEAD is the last one I need. All my other outstanding submissions are HEAD-only, not needed for backporting. |
Contributor
|
Okay, this is for master, has already been approved as part of another MR, but this is a small one easily picked out. @kroeckx, can you review this? |
qloong
pushed a commit
to tianocore/edk2
that referenced
this pull request
Mar 5, 2016
This is pull request #755 for OpenSSL 1.1, along with a little extra fix in the RSA_NET code which has been removed from 1.1 so we can't fix it there. openssl/openssl#755 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> Reviewed-by: Qin Long <qin.long@intel.com> Tested-by: Qin Long <qin.long@intel.com>
Member
|
+1 |
Contributor
|
commit db92231 thanks. |
mdkinney
pushed a commit
to mdkinney/edk2
that referenced
this pull request
Mar 8, 2016
This is pull request tianocore#755 for OpenSSL 1.1, along with a little extra fix in the RSA_NET code which has been removed from 1.1 so we can't fix it there. openssl/openssl#755 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> Reviewed-by: Qin Long <qin.long@intel.com> Tested-by: Qin Long <qin.long@intel.com>
hwu25
pushed a commit
to tianocore/edk2
that referenced
this pull request
Mar 14, 2016
This is pull request #755 for OpenSSL 1.1, along with a little extra fix in the RSA_NET code which has been removed from 1.1 so we can't fix it there. openssl/openssl#755 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> Reviewed-by: Qin Long <qin.long@intel.com> Tested-by: Qin Long <qin.long@intel.com> (cherry picked from commit 42d6834)
lcp
pushed a commit
to lcp/edk2
that referenced
this pull request
Jul 29, 2016
This is pull request tianocore#755 for OpenSSL 1.1, along with a little extra fix in the RSA_NET code which has been removed from 1.1 so we can't fix it there. openssl/openssl#755 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> Reviewed-by: Qin Long <qin.long@intel.com> Tested-by: Qin Long <qin.long@intel.com>
moocon
pushed a commit
to moocon/EDK2_sourceforge_SVN
that referenced
this pull request
Sep 25, 2022
This is pull request #755 for OpenSSL 1.1, along with a little extra fix in the RSA_NET code which has been removed from 1.1 so we can't fix it there. openssl/openssl#755 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> Reviewed-by: Qin Long <qin.long@intel.com> Tested-by: Qin Long <qin.long@intel.com> (cherry picked from commit 42d683426792b34c7538a07ade47a20e3d9929bf) (cherry picked from commit 7d5bdbe3003225175f156e62e9d1d9a7c5044c06)
makubacki
pushed a commit
to tianocore/edk2-crypto
that referenced
this pull request
Dec 4, 2025
This is pull request #755 for OpenSSL 1.1, along with a little extra fix in the RSA_NET code which has been removed from 1.1 so we can't fix it there. openssl/openssl#755 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> Reviewed-by: Qin Long <qin.long@intel.com> Tested-by: Qin Long <qin.long@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already reviewed by @richsalz as part of #729 but I'm separating it out into its own request as suggested there.
It has the distinction of being the last thing I need in OpenSSL HEAD before I can say that all the UEFI patches against 1.0.2 are backports from upstream — which is an important milestone. There's more to be done in HEAD (all in pull requests already), but it would be excellent to be able to reach this milestone for our 1.0.2 patches by merging this one.
Then I can get most of my cleanups and build system improvement (generating opensslconf.h and the file list from OpenSSL's Configure script automatically instead of manually maintaining them), into the upstream UEFI build tree.