Closed
Conversation
The code is trying to interpolate the value of the BASE_SECTION macro, but due to excess escaping, it instead prints the string "BASE_SECTION".
Member
|
+1 |
Contributor
|
fixed in 44fdf1c thanks. |
levitte
pushed a commit
to openssl/web
that referenced
this pull request
Jul 26, 2018
Reviewed-by: Viktor Dukhovni <viktor@openssl.org> (Merged from openssl/openssl#64)
1 task
openssl-machine
pushed a commit
that referenced
this pull request
Nov 16, 2022
CLA: trivial Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #19670)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 16, 2022
openssl-machine
pushed a commit
that referenced
this pull request
Nov 16, 2022
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Dec 26, 2022
CLA: trivial Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl#19670)
julian-klode
added a commit
to julian-klode/openssl
that referenced
this pull request
Jan 18, 2025
Commit 1d1ca79 introduced save and restore for the registers, saving them as stp d8,d9,[sp, openssl#16] stp d10,d11,[sp, openssl#32] stp d12,d13,[sp, openssl#48] stp d14,d15,[sp, openssl#64] But the restore code was inadvertently typoed: ldp d8,d9,[sp, openssl#16] ldp d10,d11,[sp, openssl#32] ldp d12,d13,[sp, openssl#48] ldp d15,d16,[sp, openssl#64] Restoring [sp, openssl#64] into d15,d16 instead of d14,d15. Fixes: openssl#26466
julian-klode
added a commit
to julian-klode/openssl
that referenced
this pull request
Jan 18, 2025
Commit 1d1ca79 introduced save and restore for the registers, saving them as stp d8,d9,[sp, openssl#16] stp d10,d11,[sp, openssl#32] stp d12,d13,[sp, openssl#48] stp d14,d15,[sp, openssl#64] But the restore code was inadvertently typoed: ldp d8,d9,[sp, openssl#16] ldp d10,d11,[sp, openssl#32] ldp d12,d13,[sp, openssl#48] ldp d15,d16,[sp, openssl#64] Restoring [sp, openssl#64] into d15,d16 instead of d14,d15. Fixes: openssl#26466 CLA: trivial
julian-klode
added a commit
to julian-klode/openssl
that referenced
this pull request
Jan 18, 2025
Commit 1d1ca79 introduced save and restore for the registers, saving them as stp d8,d9,[sp, openssl#16] stp d10,d11,[sp, openssl#32] stp d12,d13,[sp, openssl#48] stp d14,d15,[sp, openssl#64] But the restore code was inadvertently typoed: ldp d8,d9,[sp, openssl#16] ldp d10,d11,[sp, openssl#32] ldp d12,d13,[sp, openssl#48] ldp d15,d16,[sp, openssl#64] Restoring [sp, openssl#64] into d15,d16 instead of d14,d15. Fixes: openssl#26466 CLA: trivial
openssl-machine
pushed a commit
that referenced
this pull request
Jan 21, 2025
Commit 1d1ca79 introduced save and restore for the registers, saving them as stp d8,d9,[sp, #16] stp d10,d11,[sp, #32] stp d12,d13,[sp, #48] stp d14,d15,[sp, #64] But the restore code was inadvertently typoed: ldp d8,d9,[sp, #16] ldp d10,d11,[sp, #32] ldp d12,d13,[sp, #48] ldp d15,d16,[sp, #64] Restoring [sp, #64] into d15,d16 instead of d14,d15. Fixes: #26466 CLA: trivial Reviewed-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #26469)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 21, 2025
Commit 1d1ca79 introduced save and restore for the registers, saving them as stp d8,d9,[sp, #16] stp d10,d11,[sp, #32] stp d12,d13,[sp, #48] stp d14,d15,[sp, #64] But the restore code was inadvertently typoed: ldp d8,d9,[sp, #16] ldp d10,d11,[sp, #32] ldp d12,d13,[sp, #48] ldp d15,d16,[sp, #64] Restoring [sp, #64] into d15,d16 instead of d14,d15. Fixes: #26466 CLA: trivial Reviewed-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #26469) (cherry picked from commit 5261f3c)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 21, 2025
Commit 1d1ca79 introduced save and restore for the registers, saving them as stp d8,d9,[sp, #16] stp d10,d11,[sp, #32] stp d12,d13,[sp, #48] stp d14,d15,[sp, #64] But the restore code was inadvertently typoed: ldp d8,d9,[sp, #16] ldp d10,d11,[sp, #32] ldp d12,d13,[sp, #48] ldp d15,d16,[sp, #64] Restoring [sp, #64] into d15,d16 instead of d14,d15. Fixes: #26466 CLA: trivial Reviewed-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #26469) (cherry picked from commit 5261f3c)
VladGud
pushed a commit
to VladGud/openssl
that referenced
this pull request
Oct 9, 2025
modernize ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code is trying to interpolate the value of the BASE_SECTION macro,
but due to excess escaping, it instead prints the string "BASE_SECTION".