Skip to content

Fix ecparam -genkey with point compression or DER outform #5741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bernd-edlinger wants to merge 1 commit into from
Closed

Fix ecparam -genkey with point compression or DER outform #5741

bernd-edlinger wants to merge 1 commit into from

Conversation

@bernd-edlinger
Copy link
Member

@bernd-edlinger bernd-edlinger commented Mar 24, 2018

Points are not in compressed format when ecparam -genkey is used.
DER form output is unusable when both ecgroup and eckey are written to out.

@bernd-edlinger bernd-edlinger added branch: master Applies to master branch branch: 1.0.2 Applies to OpenSSL_1_0_2-stable branch (EOL) 1.1.0 labels Mar 24, 2018
@richsalz
Copy link
Contributor

richsalz commented Mar 24, 2018

For all branches.

@bernd-edlinger bernd-edlinger added the approval: done This pull request has the required number of approvals label Mar 25, 2018
levitte pushed a commit that referenced this pull request Mar 25, 2018
@bernd-edlinger
Fix ecparam -genkey with point compression or DER outform
4bdc25b 
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #5741)
levitte pushed a commit that referenced this pull request Mar 25, 2018
@bernd-edlinger
Fix ecparam -genkey with point compression or DER outform
5edeb62 
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #5741)

(cherry picked from commit 4bdc25b)
levitte pushed a commit that referenced this pull request Mar 25, 2018
@bernd-edlinger
Fix ecparam -genkey with point compression or DER outform
d591f30 
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #5741)

(cherry picked from commit 4bdc25b)
@bernd-edlinger
Copy link
Member Author

bernd-edlinger commented Mar 25, 2018

Merged to all branches. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@richsalz richsalz richsalz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approval: done This pull request has the required number of approvals branch: master Applies to master branch branch: 1.0.2 Applies to OpenSSL_1_0_2-stable branch (EOL)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bernd-edlinger @richsalz