Improve error handling in pk7_doit #5596
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a mem allocation failed we would ignore it. This commit fixes it to always check.
richsalz
approved these changes
Mar 12, 2018
Contributor
richsalz
left a comment
There was a problem hiding this comment.
for any branches you care to do so.
Member
Author
|
Pushed. It cherry-picked cleanly to 1.1.0 and 1.0.2 so I pushed to both of those too. |
levitte
pushed a commit
that referenced
this pull request
Mar 12, 2018
If a mem allocation failed we would ignore it. This commit fixes it to always check. Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #5596)
makr
pushed a commit
to makr/openssl
that referenced
this pull request
Mar 14, 2018
If a mem allocation failed we would ignore it. This commit fixes it to always check. Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from openssl#5596) (cherry picked from commit 4718f44)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a mem allocation failed we would ignore it. This commit fixes it to
always check.