Fix propotype to include the const qualifier #5582
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dot-asm
approved these changes
Mar 10, 2018
Contributor
|
Just for curiosity: fixes for const-correctness are not considered an API change? (I know things are different between C and C++, because the former has no name mangling). |
Contributor
|
|
Contributor
|
This point has been discussed and resolved few months ago :
In short, C standard guarantee that it is ABI compatible ...
… Le 10 mars 2018 à 16:52, Matthias St. Pierre ***@***.***> a écrit :
It might force people to rewrite their code, though. So is it really allowed to backport this fix?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Member
Author
|
And this is really just a documentation change, it's already const in 1.0.2 |
Contributor
|
Adding const is okay, removing it is not. |
Member
|
It doesn't break compatibility. That's at least my reasoning. |
levitte
pushed a commit
that referenced
this pull request
Mar 11, 2018
Reviewed-by: Andy Polyakov <appro@openssl.org> GH: #5582
levitte
pushed a commit
that referenced
this pull request
Mar 11, 2018
Reviewed-by: Andy Polyakov <appro@openssl.org> GH: #5582
levitte
pushed a commit
that referenced
this pull request
Mar 11, 2018
Reviewed-by: Andy Polyakov <appro@openssl.org> GH: #5582
makr
pushed a commit
to makr/openssl
that referenced
this pull request
Mar 14, 2018
Reviewed-by: Andy Polyakov <appro@openssl.org> GH: openssl#5582
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.