Skip to content

Conversation

@mspncp
Copy link
Contributor

@mspncp mspncp commented Mar 7, 2018

BIO_get_mem_data() and BIO_get_mem_ptr() assign to *pp, not pp

To be fixed in master, 1.1.0, and 1.0.2.

master

doc/man3/BIO_s_mem.pod:59:BIO_get_mem_data() sets B<pp> to a pointer to the start of the memory BIOs data
doc/man3/BIO_s_mem.pod:66:BIO_get_mem_ptr() places the underlying BUF_MEM structure in B<pp>. It is

1.0.2

doc/crypto/BIO_s_mem.pod:53:BIO_get_mem_data() sets B<pp> to a pointer to the start of the memory BIOs data
doc/crypto/BIO_s_mem.pod:60:BIO_get_mem_ptr() places the underlying BUF_MEM structure in B<pp>. It is

1.1.0

doc/crypto/BIO_s_mem.pod:59:BIO_get_mem_data() sets B<pp> to a pointer to the start of the memory BIOs data
doc/crypto/BIO_s_mem.pod:66:BIO_get_mem_ptr() places the underlying BUF_MEM structure in B<pp>. It is
Checklist
  • documentation is added or updated

BIO_get_mem_data() and BIO_get_mem_ptr() assign to *pp, not pp
@mspncp mspncp added branch: master Applies to master branch branch: 1.0.2 Applies to OpenSSL_1_0_2-stable branch (EOL) 1.1.0 labels Mar 7, 2018
levitte pushed a commit that referenced this pull request Mar 7, 2018
BIO_get_mem_data() and BIO_get_mem_ptr() assign to *pp, not pp

Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #5544)
levitte pushed a commit that referenced this pull request Mar 7, 2018
BIO_get_mem_data() and BIO_get_mem_ptr() assign to *pp, not pp

Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #5544)
@mspncp
Copy link
Contributor Author

mspncp commented Mar 7, 2018

Merged, thanks!

@mspncp mspncp closed this Mar 7, 2018
levitte pushed a commit that referenced this pull request Mar 7, 2018
BIO_get_mem_data() and BIO_get_mem_ptr() assign to *pp, not pp

Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #5544)
@mspncp mspncp deleted the pr-man-bio-s-mem-fix-pp-indirection branch March 7, 2018 14:29
makr pushed a commit to makr/openssl that referenced this pull request Mar 14, 2018
BIO_get_mem_data() and BIO_get_mem_ptr() assign to *pp, not pp

Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from openssl#5544)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch: master Applies to master branch branch: 1.0.2 Applies to OpenSSL_1_0_2-stable branch (EOL)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants