Skip to content

Fix error-path memory leak in asn_mime.c #5142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tmshort wants to merge 1 commit into from
Closed

Fix error-path memory leak in asn_mime.c #5142

tmshort wants to merge 1 commit into from

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Jan 22, 2018 •
edited
Loading

Need to free 'parts'.

bernd-edlinger
bernd-edlinger requested changes Jan 22, 2018
View reviewed changes
crypto/asn1/asn_mime.c Outdated
Copy link
Member

@bernd-edlinger bernd-edlinger Jan 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already done above.

Copy link
Contributor Author

@tmshort tmshort Jan 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, copy/paste error on my part... will update.

@mattcaswell mattcaswell added the approval: done This pull request has the required number of approvals label Jan 24, 2018
@mattcaswell
Copy link
Member

mattcaswell commented Jan 24, 2018

Which branches does this apply to?

@mattcaswell mattcaswell added this to the 1.1.1 milestone Jan 24, 2018
@tmshort
Copy link
Contributor Author

tmshort commented Jan 24, 2018

Which branches does this apply to?

Looks to be master, 1.1.0 and 1.0.2

@mattcaswell mattcaswell added branch: master Applies to master branch branch: 1.0.2 Applies to OpenSSL_1_0_2-stable branch (EOL) 1.1.0 labels Jan 24, 2018
@mattcaswell
Copy link
Member

mattcaswell commented Jan 24, 2018

My approval counts for all branches. @bernd-edlinger?

@bernd-edlinger
Copy link
Member

bernd-edlinger commented Jan 24, 2018

yes, good you asked....
mine counts for all branches as well.

levitte pushed a commit that referenced this pull request Jan 24, 2018
@tmshort @mattcaswell
Fix error-path memory leak in asn_mime.c
a26dd46 
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #5142)
levitte pushed a commit that referenced this pull request Jan 24, 2018
@tmshort @mattcaswell
Fix error-path memory leak in asn_mime.c
9716b12 
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #5142)

(cherry picked from commit a26dd46)
levitte pushed a commit that referenced this pull request Jan 24, 2018
@tmshort @mattcaswell
Fix error-path memory leak in asn_mime.c
d19bf13 
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #5142)

(cherry picked from commit a26dd46)
@mattcaswell
Copy link
Member

mattcaswell commented Jan 24, 2018

Pushed. Thanks.

@tmshort tmshort deleted the master-leak branch March 26, 2018 14:15
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this pull request Nov 11, 2021
@tmshort @bernd-edlinger
Fix error-path memory leak in asn_mime.c
9870db4 
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl#5142)

(cherry picked from commit a26dd46)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

@bernd-edlinger bernd-edlinger bernd-edlinger approved these changes

Assignees

No one assigned

Labels

approval: done This pull request has the required number of approvals branch: master Applies to master branch branch: 1.0.2 Applies to OpenSSL_1_0_2-stable branch (EOL)

Projects

None yet

Milestone

1.1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@tmshort @mattcaswell @bernd-edlinger