Fix SSL_CTX_get_{min,max}_proto_version integer conversion warning#5099
Closed
syzzer wants to merge 1 commit intoopenssl:masterfrom
Closed
Fix SSL_CTX_get_{min,max}_proto_version integer conversion warning#5099syzzer wants to merge 1 commit intoopenssl:masterfrom
syzzer wants to merge 1 commit intoopenssl:masterfrom
Conversation
When using the SSL_CTX_get_min_min_version macro while compiling with -Wall, my compiler rightfully complains about this construction: warning: passing argument 3 of ‘SSL_CTX_ctrl’ makes integer from pointer without a cast [-Wint-conversion] These macro's should use 0, instead of NULL, for the third argument, like most other SSL_CTX_ctrl 'get' wrappers do. CLA: trivial Signed-off-by: Steffan Karger <steffan.karger@fox-it.com>
4e44e88 to
61e1996
Compare
kaduk
approved these changes
Jan 17, 2018
Contributor
kaduk
left a comment
There was a problem hiding this comment.
Formality: I agree this is trivial.
(@syzzer if you put the literal text "CLA: trivial" on a line by itself in the body of the commit message, usually at at the end of it, that will appease the cla-bot check. But your current note should be enough for this time.)
kroeckx
approved these changes
Jan 17, 2018
mattcaswell
approved these changes
Jan 24, 2018
Member
mattcaswell
left a comment
There was a problem hiding this comment.
I agree this is trivial. @kaduk - will you merge?
Contributor
|
I will merge, but see also my comment on #5126. |
levitte
pushed a commit
that referenced
this pull request
Jan 24, 2018
When using the SSL_CTX_get_min_min_version macro while compiling with -Wall, my compiler rightfully complains about this construction: warning: passing argument 3 of ‘SSL_CTX_ctrl’ makes integer from pointer without a cast [-Wint-conversion] These macro's should use 0, instead of NULL, for the third argument, like most other SSL_CTX_ctrl 'get' wrappers do. CLA: trivial Signed-off-by: Steffan Karger <steffan.karger@fox-it.com> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Ben Kaduk <kaduk@mit.edu> (Merged from #5099)
levitte
pushed a commit
that referenced
this pull request
Jan 24, 2018
When using the SSL_CTX_get_min_min_version macro while compiling with -Wall, my compiler rightfully complains about this construction: warning: passing argument 3 of ‘SSL_CTX_ctrl’ makes integer from pointer without a cast [-Wint-conversion] These macro's should use 0, instead of NULL, for the third argument, like most other SSL_CTX_ctrl 'get' wrappers do. CLA: trivial Signed-off-by: Steffan Karger <steffan.karger@fox-it.com> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Ben Kaduk <kaduk@mit.edu> (Merged from #5099) (cherry picked from commit 78d0afa)
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the SSL_CTX_get_min_min_version macro while compiling with
-Wall, my compiler rightfully complains about this construction:
warning: passing argument 3 of ‘SSL_CTX_ctrl’ makes integer from
pointer without a cast [-Wint-conversion]
These macro's should use 0, instead of NULL, for the third argument,
like most other SSL_CTX_ctrl 'get' wrappers do.
Signed-off-by: Steffan Karger steffan.karger@fox-it.com
I consider this to be a 'trivial' contribution, but am willing to sign a CLA if needed.