Add missing tests to the VMS test scripts #5017
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to Douglas Fyfe @ VSI for making me aware of this
richsalz
approved these changes
Jan 4, 2018
| "CONSTANT_TIME_TEST,VERIFY_EXTRA_TEST,"+ - | ||
| "CLIENTHELLOTEST,SSLV2CONFTEST,DTLSTEST" | ||
| "CLIENTHELLOTEST,SSLV2CONFTEST,DTLSTEST,"+ - | ||
| "BAD_DTLS_TEST,FATALERRTEST" |
Contributor
There was a problem hiding this comment.
while you're in the area, it would be nice to update the comment at line 155 to remove outdated test names.
Member
Author
There was a problem hiding this comment.
Uhmmmm... I'm thinking I should remove that line, is that what you mean?
Member
Author
There was a problem hiding this comment.
I decided to do so. Reconfirm?
Contributor
There was a problem hiding this comment.
reconfirm. I just wanted the outdated comment fixed, in whatever was most appropriate :)
levitte
added a commit
that referenced
this pull request
Jan 6, 2018
Thanks to Douglas Fyfe @ VSI for making me aware of this Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #5017)
levitte
added a commit
that referenced
this pull request
Jan 6, 2018
Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #5017)
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Douglas Fyfe @ VSI for making me aware of this